Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If Project or Solution path contains spaces then the build command fails #37

Closed
DuncanMT opened this issue Feb 1, 2022 · 4 comments
Closed

Comments

@DuncanMT
Copy link

DuncanMT commented Feb 1, 2022

I discovered this when trying to use this plugin in a jenkins environemnt where each job names hapened to contain spaces:

Since the build_command_generator.rb does not quote the path to the project or solution it fails to find the solution or project since you are using absolute paths.

Solution

  if config[:solution_path]
    solution_dir = File.dirname(config[:solution_path])
    options << "-p:SolutionDir=#{solution_dir}/"
  end

Project

 path << Souyuz.config[:project_path] # if Souyuz.project.android?
@voydz
Copy link
Owner

voydz commented Feb 9, 2022

Hey @DuncanMT ,

are you willing to make a merge request for this issue, too? I would love to merge it.

best regards

@DuncanMT
Copy link
Author

DuncanMT commented Feb 9, 2022

PR created, not sure if other paths will have the same error, but this definitely enables builds.

@voydz
Copy link
Owner

voydz commented Feb 9, 2022

should be fixed with #38

@voydz voydz closed this as completed Feb 9, 2022
@voydz
Copy link
Owner

voydz commented Feb 9, 2022

thanks again!

your merge requests are available in version 0.11.1 on rubygems.

best regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants