Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quotes around project and solution paths to fix error #38

Merged
merged 1 commit into from
Feb 9, 2022
Merged

Add quotes around project and solution paths to fix error #38

merged 1 commit into from
Feb 9, 2022

Conversation

DuncanMT
Copy link

@DuncanMT DuncanMT commented Feb 9, 2022

Fix for issue #37 .

Added quotes around project and solution paths in build_command_generator.rb.

Bumped version to 0.11.1.

Tested terminal output with space in path at 'projects/Fastlane Test/src' :

+---------------------+-------------------------------------------------------------------------------+
|                                      Summary for souyuz 0.11.1                                      |
+---------------------+-------------------------------------------------------------------------------+
| build_configuration | Release                                                                       |
| platform            | android                                                                       |
| build_platform      | AnyCPU                                                                        |
| solution_path       | /Users/duncan/projects/Fastlane Test/FastlaneTest.sln                         |
| project_name        | FastlaneTest.Droid                                                            |
| project_path        | /Users/duncan/projects/Fastlane                                               |
|                     | Test/src/FastlaneTest.Droid/FastlaneTest.Droid.csproj                         |
| output_path         | /Users/duncan/projects/Fastlane Test/src/FastlaneTest.Droid/bin/Release/      |
| manifest_path       | /Users/duncan/projects/Fastlane                                               |
|                     | Test/src/FastlaneTest.Droid/Properties/AndroidManifest.xml                    |
| buildtools_path     | /Users/duncan/Library/Developer/Xamarin/android-sdk-macosx/build-tools/30.0.2 |
| assembly_name       | com.<company>.fastlanetest                                                    |
| silent              | false                                                                         |
| compiler_bin        | msbuild                                                                       |
| build_target        | ["Build"]                                                                     |
| keystore_tsa        | http://timestamp.digicert.com                                                 |
+---------------------+-------------------------------------------------------------------------------+

[14:45:06]: $  msbuild -p:Configuration=Release -p:SolutionDir="/Users/duncan/projects/Fastlane Test/" -t:Build -t:SignAndroidPackage "/Users/duncan/projects/Fastlane Test/src/FastlaneTest.Droid/FastlaneTest.Droid.csproj"
[14:45:08]: ▸
Microsoft (R) Build Engine version 16.9.0 for Mono
[14:45:08]: ▸ Copyright (C) Microsoft Corporation. All rights reserved.
^[[64;15R[14:45:08]: ▸ Build started 09/02/2022 14:45:08.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants