Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Cesium ext_instance_features #201

Merged
merged 17 commits into from
Nov 30, 2023

Conversation

bertt
Copy link
Contributor

@bertt bertt commented Nov 14, 2023

Add Cesium extension EXT_instance_features support. Specs: https://github.com/CesiumGS/glTF/tree/3d-tiles-next/extensions/2.0/Vendor/EXT_instance_features

This extension must be used with the EXT_mesh_gpu_instancing extension.

Sample node:

 "nodes": [
    {
      "extensions": {
        "EXT_mesh_gpu_instancing": {
          "attributes": {
            "TRANSLATION": 4,
            "_FEATURE_ID_0": 5
          }
        },
        "EXT_instance_features": {
          "featureIds": [
            {
              "attribute": 0,
              "featureCount": 2,
              "label": "Forests",
              "nullFeatureId": 2,
              "propertyTable": 0
            },
            {
              "featureCount": 9,
              "label": "Trees",
              "propertyTable": 1
            }
          ]
        }
      },
      "mesh": 0
    }
  ],

@bertt bertt marked this pull request as draft November 14, 2023 14:32
@bertt bertt changed the title add Cesium extension ext_instance_features add Cesium ext_instance_features Nov 14, 2023
@bertt bertt marked this pull request as ready for review November 27, 2023 15:57
@vpenades
Copy link
Owner

So far I don't see any problems, other than adjusting the tests to NUnit 4.0

@vpenades vpenades merged commit 363bc72 into vpenades:master Nov 30, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants