Fix configuration issues, update iprose-go #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemirk
reviewed
May 17, 2024
internal/iprose/instance.go
Outdated
| @@ -26,12 +38,33 @@ type Instance struct { | |||
| config *Config | |||
| } | |||
|
|
|||
| func fillDefaults(config *Config) *Config { | |||
| filled := *config | |||
There was a problem hiding this comment.
What's the point to make a copy?
artemirk
reviewed
May 17, 2024
internal/iprose/instance_stub.go
Outdated
| @@ -13,6 +13,8 @@ type Instance struct { | |||
| stopped bool | |||
| } | |||
|
|
|||
| var DefaultConfig = &Config{} | |||
There was a problem hiding this comment.
Probably better declare it as value with predefined (default values)
artemirk
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.