Added override constructor to ClientSSLSecurityPFX class (#1184)

* Added override constructor to ClientSSLSecurityPFX class Added test for additional ClientSSLSecurityPFX constructor Fixed failing test of ClientSSLSecurityPFX * Disabling test using and removing files PurchasingRequestService due to 404 links
vpulim · Jun 6, 2022 · e4f7106 · e4f7106
1 parent 56c7942
commit e4f7106
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 1,253 deletions.
diff --git a/src/security/ClientSSLSecurityPFX.ts b/src/security/ClientSSLSecurityPFX.ts
@@ -18,6 +18,7 @@ export class ClientSSLSecurityPFX implements ISecurity {
   private passphrase: string;
 
   constructor(pfx: string | Buffer, defaults?: any);
+  constructor(pfx: string | Buffer, passphrase: string, defaults?: any);
   constructor(pfx: string | Buffer, passphrase: string, defaults?: any) {
     if (typeof passphrase === 'object') {
       defaults = passphrase;

diff --git a/test/client-test.js b/test/client-test.js
@@ -1610,7 +1610,7 @@ it('should create async client without options', function (done) {
   });
 });
 
-it('should add namespace to array of objects', function (done) {
+xit('should add namespace to array of objects', function (done) {
   soap.createClientAsync(__dirname + '/wsdl/PurchaseRequestService.wsdl').then(function (client) {
     const input = {
       errorProcessingLevel: "ALL",

diff --git a/test/security/ClientSSLSecurityPFX.js b/test/security/ClientSSLSecurityPFX.js
@@ -23,6 +23,14 @@ describe('ClientSSLSecurityPFX', function() {
       instance.addOptions(options);
       options.should.have.property("foo", 5);
     });
+
+    it('should be accepted as the third param', function() {
+      var pfkBuffer = fs.readFileSync(join(__dirname, '..', 'certs', 'client-password.pfx')), 
+        instance;
+
+      instance = new ClientSSLSecurityPFX(pfkBuffer, 'test2est', { foo: 5});
+      instance.should.have.property("defaults", { foo: 5 })
+    })
   });
 
   it('should throw if invalid pfk file is given', function () {