Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added override constructor to ClientSSLSecurityPFX class #1184

Merged
merged 2 commits into from Jun 6, 2022

Conversation

willemruys
Copy link
Contributor

The declaration of constructor overloads for ClientSSLSecurityPFX was missing one constructor definition. As a consequence, ClientSSLSecurityPFX.d.ts defined only one constructor:

../ClientSSLSecurityPFX.d.ts

export declare class ClientSSLSecurityPFX implements ISecurity {
    private pfx;
    private defaults;
    private passphrase;
    constructor(pfx: string | Buffer, defaults?: any);
    toXML(): string;
    addOptions(options: any): void;
}

I've added the constructor definition and the definition file showed both constructor methods.

@jsdevel
Copy link
Collaborator

jsdevel commented May 11, 2022

@willemruys please add a test

@willemruys
Copy link
Contributor Author

@jsdevel I've added a test and squashed my commits into 1 commit. Please let me know if I can do anything else.

@jsdevel
Copy link
Collaborator

jsdevel commented May 13, 2022

@willemruys can you fix the build?

Added test for additional ClientSSLSecurityPFX constructor

Fixed failing test of ClientSSLSecurityPFX
@willemruys
Copy link
Contributor Author

@jsdevel Done! I fixed the failing test

@willemruys
Copy link
Contributor Author

@jsdevel sorry for the trouble. Some tests in the WSDLParser seem to be failing. Not sure what caused it. I’ll have a look tomorrow or Monday and push a fix.

@willemruys
Copy link
Contributor Author

Unfortunately, the failing tests seem to be unrelated to my changes and what I can see from other PRs, they are occurring there as well. I'll try to do my best to fix them.

@jsdevel
Copy link
Collaborator

jsdevel commented May 18, 2022

i'm willing to accept that the test may have to be removed. i think the failing test is trying to fetch XSD files that are now 404.

@willemruys
Copy link
Contributor Author

@jsdevel I've disabled the test using the PurchaseRequestService.wsdl and deleted the PurchaseRequestService files since they indeed contained links that returned 404.

@tommyhtran
Copy link
Contributor

@jsdevel Is there anything holding up this PR?

@jsdevel jsdevel merged commit e4f7106 into vpulim:master Jun 6, 2022
sandrozbinden-axa pushed a commit to axa-health/node-soap that referenced this pull request Oct 6, 2022
* Added override constructor to ClientSSLSecurityPFX class

Added test for additional ClientSSLSecurityPFX constructor

Fixed failing test of ClientSSLSecurityPFX

* Disabling test using and removing files PurchasingRequestService due to 404 links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants