New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added override constructor to ClientSSLSecurityPFX class #1184
Conversation
@willemruys please add a test |
@jsdevel I've added a test and squashed my commits into 1 commit. Please let me know if I can do anything else. |
@willemruys can you fix the build? |
Added test for additional ClientSSLSecurityPFX constructor Fixed failing test of ClientSSLSecurityPFX
@jsdevel Done! I fixed the failing test |
@jsdevel sorry for the trouble. Some tests in the WSDLParser seem to be failing. Not sure what caused it. I’ll have a look tomorrow or Monday and push a fix. |
Unfortunately, the failing tests seem to be unrelated to my changes and what I can see from other PRs, they are occurring there as well. I'll try to do my best to fix them. |
i'm willing to accept that the test may have to be removed. i think the failing test is trying to fetch XSD files that are now 404. |
@jsdevel I've disabled the test using the PurchaseRequestService.wsdl and deleted the PurchaseRequestService files since they indeed contained links that returned 404. |
@jsdevel Is there anything holding up this PR? |
* Added override constructor to ClientSSLSecurityPFX class Added test for additional ClientSSLSecurityPFX constructor Fixed failing test of ClientSSLSecurityPFX * Disabling test using and removing files PurchasingRequestService due to 404 links
The declaration of constructor overloads for ClientSSLSecurityPFX was missing one constructor definition. As a consequence,
ClientSSLSecurityPFX.d.ts
defined only one constructor:I've added the constructor definition and the definition file showed both constructor methods.