Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added override constructor to ClientSSLSecurityPFX class #1184

Merged
merged 2 commits into from
Jun 6, 2022
Merged

Added override constructor to ClientSSLSecurityPFX class #1184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0786d35
Added override constructor to ClientSSLSecurityPFX class
May 11, 2022
1cac578
Disabling test using and removing files PurchasingRequestService due …
May 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions src/security/ClientSSLSecurityPFX.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ export class ClientSSLSecurityPFX implements ISecurity {
private passphrase: string;

constructor(pfx: string | Buffer, defaults?: any);
constructor(pfx: string | Buffer, passphrase: string, defaults?: any);
constructor(pfx: string | Buffer, passphrase: string, defaults?: any) {
if (typeof passphrase === 'object') {
defaults = passphrase;
Expand Down
2 changes: 1 addition & 1 deletion test/client-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1610,7 +1610,7 @@ it('should create async client without options', function (done) {
});
});

it('should add namespace to array of objects', function (done) {
xit('should add namespace to array of objects', function (done) {
soap.createClientAsync(__dirname + '/wsdl/PurchaseRequestService.wsdl').then(function (client) {
const input = {
errorProcessingLevel: "ALL",
Expand Down
8 changes: 8 additions & 0 deletions test/security/ClientSSLSecurityPFX.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,14 @@ describe('ClientSSLSecurityPFX', function() {
instance.addOptions(options);
options.should.have.property("foo", 5);
});

it('should be accepted as the third param', function() {
var pfkBuffer = fs.readFileSync(join(__dirname, '..', 'certs', 'client-password.pfx')),
instance;

instance = new ClientSSLSecurityPFX(pfkBuffer, 'test2est', { foo: 5});
instance.should.have.property("defaults", { foo: 5 })
})
});

it('should throw if invalid pfk file is given', function () {
Expand Down