AssertionError: Invalid child type when WSDL contains imports or includes

[boustanihani]

Any WSDL containing imports or includes will cause following error => "AssertionError: Invalid child type"
Sample WSDL to reproduce the issue => test/wsdl/strict/reproduce_issues_125_and_312.wsdl

Check: https://github.com/vpulim/node-soap/issues/125 (Almost a year ago)
Also Check : https://github.com/vpulim/node-soap/issues/312

I suggest those types of elements are ignored temporary until node-soap has some logic to handle them.

[jsdevel]

@boustanihani looks good. The travis build failed though https://travis-ci.org/vpulim/node-soap/jobs/22829904#L366

[boustanihani]

It says WSDL Parser (strict) should parse and describe reproduce_issues_125_and_312.wsdl:
Uncaught Error: Found unexpected element (wsdl:import) inside wsdl:definitions

[jsdevel]

@boustanihani did you run npm test before pushing?

[boustanihani]

no I did not :)

[boustanihani]

I am new to using Git and this was my first Pull Request ever...

The main issue is that node-soap has no logic to handle includes & imports. So an "AssertionError: Invalid child type" is automatically thrown when such an element is found... I thought it is good to ignore those elements temporarily until node-soap has logic to handle them...

[jsdevel]

@boustanihani glad I could be here for your first Pull Request!

What happens when you comment out your fix? Do you get a different error?

[boustanihani]

Before the fix I was getting "AssertionError: Invalid child type" and after I put my fix there were no more errors... You know, WSDLs sometimes have "import" elements like in the sample I posted and node-soap has no logic to deal with such elements and for this reason node-soap regards such elements as invalid and thows the error above!

Check: http://www.w3.org/TR/wsdl#_document-n
2.1.1 Document Naming and Linking
WSDL allows associating a namespace with a document location using an import statement:

<definitions .... >
    <import namespace="uri" location="uri"/> *
</definitions>

[boustanihani]

It is exactly this function which fails when child.name === "import" =>

AssertionError: Invalid child type
at DefinitionsElement.addChild (../node_modules/soap/lib/wsdl.js:383:5)

//...

DefinitionsElement.prototype.addChild = function(child) {
  var self = this;
  if (child instanceof TypesElement) {
    self.schemas = child.schemas;
  }
  else if (child instanceof MessageElement) {
    self.messages[child.$name] = child;
  }
  else if (child instanceof PortTypeElement) {
    self.portTypes[child.$name] = child;
  }
  else if (child instanceof BindingElement) {
    if (child.transport === 'http://schemas.xmlsoap.org/soap/http' ||
      child.transport === 'http://www.w3.org/2003/05/soap/bindings/HTTP/')
      self.bindings[child.$name] = child;
  }
  else if (child instanceof ServiceElement) {
    self.services[child.$name] = child;
  }
  else if (child instanceof DocumentationElement) {
  }
  else {
    assert(false, "Invalid child type");
  }
  this.children.pop();
};

//...

[nikmartin]

Another test case:
https://webservice.kareo.com/services/soap/2.1/KareoServices.svc?wsdl

[j03w]

Umm, I think I may have fixed this see: commit. Although, I don't think it is quite right, semantic-wise but I don't really know much about XML orSOAP or WSDL so please let me know if you have any suggestion on how to improve it…

I also added a test case using http://api.temando.com/schema/2009_06/server.wsdl and it seems to work correctly, with import at the least.

OK, I made a new PR #337