Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed AssertionError: Invalid child type when WSDL contains imports #337

Merged
merged 1 commit into from
May 7, 2014

Conversation

j03w
Copy link

@j03w j03w commented May 6, 2014

Fixed #322

@jsdevel
Copy link
Collaborator

jsdevel commented May 6, 2014

@j03w thanks for this! Couple of things:

  1. You'll need to rebase / squash down to a single commit for history purposes.
  2. The WSDLs need to be reduced in size so as to take up less space.

Once those are addressed this will get merged.

@j03w
Copy link
Author

j03w commented May 6, 2014

@jsdevel thank for the quick respond!

I'm going to do those real quick. Although, I just realised that the wsdl and xsd files I got there are copyrighted and I'm not suppose to redistribute them, worst I'm not suppose to modify them. So I'm in a process of hunting for suitable wsdl to add as a test case.

@j03w
Copy link
Author

j03w commented May 6, 2014

@jsdevel done! Not sure how legit it is for my test case though.

@jsdevel
Copy link
Collaborator

jsdevel commented May 7, 2014

Thanks @j03w! The idea is that your samples document what node-soap should do under what conditions. That way when others change the module in the future, and tests break, we can look at the samples to identify what exactly node-soap should be doing but isn't.

Given that, can you ammend your commit message? I'd prefer to see a more meaningful commit message in terms of history. The subject you used when filing the issue would suffice.

@j03w
Copy link
Author

j03w commented May 7, 2014

@jsdevel done but I think I clicked the wrong button -_-' sorry I'm not very familiar with Github

@j03w j03w closed this May 7, 2014
@j03w j03w reopened this May 7, 2014
jsdevel added a commit that referenced this pull request May 7, 2014
Fixed `AssertionError: Invalid child type` when WSDL contains imports
@jsdevel jsdevel merged commit ea5fd95 into vpulim:master May 7, 2014
@jsdevel
Copy link
Collaborator

jsdevel commented May 7, 2014

looks good @j03w ! Thanks!

diarmaidm pushed a commit to diarmaidm/node-soap that referenced this pull request Feb 3, 2016
Fixed `AssertionError: Invalid child type` when WSDL contains imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants