Don't generate invalid dates

[mredbishop]

Don't generate invalid dates when the schema uses a date time format that is incompatible with the javascript Date object constructor such as '1987-01-01-05:00'

[coveralls]

Coverage decreased (-0.05%) to 92.097% when pulling 09e7018 on mredbishop:patch-1 into 2c9c537 on vpulim:master.

[herom]

Thanks a lot!

Perhaps we should consider to add moment.js as a dependency and allow users to pass a format string for date conversion? Would you take on the challenge to implement it?

If not, I'll be happy to merge your request but I must ask for at least 1 test for this too as is stated in our CONTRIBUTING.md.

[mredbishop]

If you're happy with that, we were planning on adding moment js to our fork of the project for exactly this reason! Should I crack on? :)

[herom]

This would be awesome @mredbishop 👍 😸

[mredbishop]

Hey @herom, where do you test the xml parsing? I've included moment and written the code to support it but I'm not sure where you are testing the xml parser from?

[mredbishop]

Never mind I got it, I'll see if I can put it together and submit a pull request.

[coveralls]

Coverage decreased (-0.003%) to 92.139% when pulling 29a08c8 on mredbishop:patch-1 into 2c9c537 on vpulim:master.

[mredbishop]

@herom I've added a test to cover this which is passing. Let me know if it needs anything else.

[jsdevel]

how about just timezone?

[facundoolano]

would it make sense to merge the first commit while you work on the moment.js feature?

[jsdevel]

we really need the API changes to be made first

[jsdevel]

closing due to inactivity