Skip to content

Commit

Permalink
Fix http:// links in stylesheets to protocol-independent ones (//)
Browse files Browse the repository at this point in the history 
The http links do not load on https pages due to mixed content restriction
of modern browsers
  • Loading branch information
@piit79 @vrana
piit79 authored and vrana committed Feb 28, 2016
1 parent 49e2ac4 commit c5a7174
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion designs/brade/adminer.css
View file
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ border:5px solid #ccc;margin:0}
#menu a{color:#333;margin-right:4px}
#menu a:hover{background:#333;color:#fff;border-color:#333}
#menu a.h1,#menu a.h1:hover{display:block;height:0;width:175px;padding:40px 0 0 0;overflow:hidden;float:left;border:0;margin:0;
outline:0;background:url(http://www.bradezone.com/random/adminer_logo.gif) no-repeat;line-height:32px}
outline:0;background:url(//www.bradezone.com/random/adminer_logo.gif) no-repeat;line-height:32px}

This comment has been minimized.

Sign in to view

Copy link
@drAlberT

drAlberT Jul 1, 2016

404
#menu p{white-space:nowrap;border:0;padding:0 0 4px 0;margin:0 0 4px 0}
#breadcrumb{background:#333;color:#fff;position:fixed;top:0;left:320px;width:100%;line-height:40px;padding:0;z-index:1;margin:0}
#breadcrumb a{color:#ff9}
Expand Down
2 changes: 1 addition & 1 deletion designs/galkaev/adminer.css
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/** theme "easy on the eyes" for Adminer by p.galkaev@miraidenshi-tech.jp */

@import url(http://fonts.googleapis.com/css?family=Source+Sans+Pro:400,900);
@import url(//fonts.googleapis.com/css?family=Source+Sans+Pro:400,900);

/* reset
----------------------------------------------------------------------- */
Expand Down
2 changes: 1 addition & 1 deletion designs/nicu/adminer.css
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/* CSS by Nicu I. - www.nicu.me */
@import url('http://fonts.googleapis.com/css?family=Roboto:400,700,300');
@import url('//fonts.googleapis.com/css?family=Roboto:400,700,300');
body {
font: 16px/1.25 'Roboto', Verdana, Arial, Helvetica, sans-serif;
margin: 0;
Expand Down
4 changes: 2 additions & 2 deletions designs/pokorny/adminer.css
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 comments on commit c5a7174

@apmuthu
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file designs/pokorny/adminer.css does not show the logout icon properly as it overlaps the top right box.

For the left menu links to appear, lines 127-137:

html>/**/body #menu p a[href*="&select="] {
    clear: left;
    display: block;
    float: left;
    height: 18px;
    margin-right: 5px;
    overflow: hidden;
    padding-left: 16px;
    text-decoration: none;
    width: 0;
}

should be

html>/**/body #menu p a[href*="&select="] {
    clear: left;
    display: block;
    float: left;
    height: 18px;
    margin-right: 5px;
    padding-left: 20px;
    text-decoration: none;
    width: 0;
}

@drAlberT
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vrana @piit79 //: is to be considered an anti-pattern:

As of December 2014, Paul Irish's blog on protocol-relative URLs says:

2014.12.17: Now that SSL is encouraged for everyone and doesn’t have performance concerns, this technique is now an anti-pattern. If the asset you need is available on SSL, then always use the https:// asset.

I really suggest to always use https:// ..

@apmuthu
Copy link

@apmuthu apmuthu commented on c5a7174 Jul 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edge cases (and double CSS downloads) in the comments in the Paul's Blog need to be taken into account.

Please sign in to comment.