List of tables implemented as <ul> #116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In Adminer, HTML table is not formatted how it should be. |
|
Why a lot of merge requests are ignored? |
|
The change to gitignore the .idea directory really shouldn't be in this repository. You should place it in your global gitignore file: https://thomashunter.name/blog/global-gitignore-vs-repository-gitignore/
Adminer aims to have a small a filesize as possible. One of the ways it does this is by abusing the fact that browsers will deal with these missing tags for legacy reasons.
I am finding this very frustrating myself personally. I submitted eight pull requests almost three months ago and haven't heard back about any of them. I'm currently maintaining my own branch with all of my modifications mixed in: https://github.com/djmattyg007/adminer/tree/custom-v4.2.4 |
|
I'm sorry, maintaining Adminer isn't much fun for me anymore. I personally use it only now and then. |
|
@vrana, thanks for your reply. It's not optimistic, but it is much better than nothing. My pull request is more than year old and I lost all hopes for hear anything from you. I understand your point of view, but be sure there ale lots of people that use Adminer nearly every day. So my question is: what's your suggestion for those who want to help and improve this project? @djmattyg007, thank you for feedback. I'll try to change my pull request. |
peterpp
force-pushed
the
master
branch
3 times, most recently
from
9ccf53e
to
e07007b
Compare
Encapsulation of list items is necessery for advanced CSS themes.
|
I reduced this pull request to one minimalist commit. |
|
@vrana what state do you think the project is in right now? If you were to hand the project over to someone else or bring someone else on board to help maintain it, what would you want them to know about it? |
|
Adminer is in maintenance mode right now. I release versions with security fixes, new translations and some random stuff. If you want more, I would suggest forking the project. Consider also renaming the fork so that it's not confusing to the users. It's possible that I will start using Adminer more in July 2016. If that happens, the pace of development will probably increase. |
|
Merged. Please make sure that this doesn't break the designs (at least the top ones at https://www.adminer.org/#extras). |
peterpp
added a commit
to pematon/adminer
that referenced
this pull request
Feb 19, 2017
peterpp
added a commit
to pematon/adminer
that referenced
this pull request
Feb 19, 2017
vrana
pushed a commit
that referenced
this pull request
Feb 20, 2017
s4muel
added a commit
to s4muel/adminer
that referenced
this pull request
May 25, 2017
* Use HTTPS Google Font URL
* Support PHP 7
* Delete unused variable and method
* Bosnian language
* Add Bosnian translation
* Add Finnish translation
* Fix remote execution in SQLite query (discovered by 庞申杰(千霄))
* Release 4.2.4
* Fix http:// links in stylesheets to protocol-independent ones (//)
The http links do not load on https pages due to mixed content restriction
of modern browsers
* improved kill command support for MySQL and initial support for PgSQL
* Remove global variable
* Fix remote execution in SQLite query (thanks to Vincent Waart)
* SQLite: Require credentials to use (thanks to Vincent Waart)
* Release 4.2.5
* Update Indonesian translation (thanks to Benny)
* Add accessibility labels to Create Table fields
* Make maxlength in edit fields a soft limit
* Add Cache-Control: immutable to static files
* Change comment not supported by compile.php
* Changed 'geraakt' to 'beinvloed' in Dutch translation
* Disallow selecting driver if there's only one
* Add SQLite auto-login plugin
* RTL layout fixes
Signed-off-by: Lucas Sandery <lucas-sandery@users.noreply.github.com>
* Additional theme with responsive and RTL support
Signed-off-by: Lucas Sandery <lucas-sandery@users.noreply.github.com>
* Escape quote in field name to make it work in Chrome (thanks to zcepenela pani)
* Add accessibility labels to databases and tables checkboxes
* Use class instead inline style
* Add accessibility labels to Indexes
* Add accessibility labels to Foreign keys
* mistype correction
* Fix error found by PHPStan
* Changed 'undefined' to 'null'
'undefined' is not a valid JSON attribute value and should been 'null'
* Fixed mssql driver for usage with microsoft's php7 sqlsrv extension
* PHP Warning hidden and better parsing times (at least for postgresql)
* Plugin which shows sql structure comments in field names title
* postgresql : ERROR: function connection_id() does not exist
* postgresql : unique partial index musn't be considered as unique. can cause problems on row edition
* Use null instead of undefined on after parsing JSON
* Added pdo_dblib as a driver for MSSQL (as native MSSQL driver does not exist for PHP7)
* Document changes
* Fixed background of the list of the tables.
* postgresql error with index on hidden columns (ctid)
* Fix index length with Postgresql
* Tabs must also be escaped in JSON strings
If database table data contains tab characters (0x09) then those
must also be escaped along with newlines and carriage returns for
the resulting JSON file to be valid.
* Plugin: Use <select> on custom user types in psql
* Added support for binary foreign keys selection on edit
* Update AdminerTablesFilter
* Removes children request (Should work on IE6, 7, 8 now)
* Uses <strong> instead of <b>
* Doesn't leave said <strong> tags behind after updating the list
* Highlights multiple matches in a single table name
* Works case insensitively
* Improves performance with setTimeout
With 400 tables, the old implementation locks up the tab (or
browser if using something without multiprocess) for about
half a second per keyup. Yes, this includes modifiers that
don't actually change the filter. The new version handles
the same event in 0.09 milliseconds.
That's with all the above improvements.
Tested in firefox 45.1.1 performance monitor.
* AdminerTablesFilter: Persist filter value in a tab
* Improve limit check in edit-foreign plugin
The limit is enforced in the query to prevent out-of-memory errors for big target tables.
* fixed Elastic table_status()
* Handle checkboxes properly in selectAddRow()
* Move rendering of table structure and indexes list into plugin system
This allows the creation of a plugin to extend the display of either or
both of these things.
* Add plugin for printing table structure in expanded format
Instead of trying to squeeze everything into three columns, this plugin
uses multiple columns for each part of a column's structure.
* Add plugin for printing table indexes structure in expanded format
* PostgreSQL export: table structure, columns, sequences, indexes, foreign keys, comments, trigger definition
* make bytea fields shortable
* New skin 'flat'
* Do not set input type as numeric if field is an array
* Add namespace to routine call
MSSQL is picky about this, shouldn't affect the drivers that don't use namespaces.
* Edit json and jsonb types in textarea
* Breadcumb no longer blocks the logout button.
Not sure why the top bar is blocking the logout button. This patch allows the user to see and click the logout button.
* Hide databases the user can't connect to
pg_database lists all databases including the ones the user can't connect to.
There is little point in showing them when we know connecting will fail.
* fix logger for SQL commands
* Fix MS SQL Driver to not show warnings for version fetching on connection and to retrieve the next set of results properly
* Changed NULL format
+ <i> was not italics
+ reduce font & showed border
* Tables list implemented as <ul>
Encapsulation of list items is necessery for advanced CSS themes.
* foreign key link fix - added missing ns
* Add javascript move for editing
* Verify commit success after import.
Fixes https://sourceforge.net/p/adminer/bugs-and-features/521/.
* PostgreSQL: Fix index size computation
* PostgreSQL: Allow changing materialized views
* Fixed all alternative designs after changes in a list of tables made here: vrana#116
* Checkbox for bool in psql
* Add basic support for MySQL replication
* Add Czech translation
* Display message about missing master status
* Add jsonly class to JS checkboxes
* Fix where() escaping in MS SQL (bug #496)
* Support high Unicode characters in shorten_utf8 (bug vrana#481)
* Use 'Create database' instead of 'Create new database'
* Move 'Create user' above the list of users
* Fix dropping foreign keys linking to other database
* MySQL: Support spatial indexes (bug vrana#455)
* Save bytes
* Elasticsearch: Support HTTPS by inputting https://server (bug vrana#446)
* Unindent
* Hide materialized views in MySQL
* Elasticsearch: allow empty server name
* Bump version
* Avoid referencing global variable (doesn't work in PHP 7.1 if Adminer is included inside a function)
* Document new engines
* Simplify SQLite development
* Lint PHP files
* Save bytes
* Update URL
* Improve SQLite login error message
* Rely on noreferrer in Firefox too
* Use SameSite cookies (except session cookie)
* Support MySQL 8
* MySQL: Support JSON data type
* Print number of bytes in blob in italics
* Highlight JSON
* Update JUSH
* Reorder changelog
* Release 4.3.0
* PostgreSQL: Fix index size computation in PostgreSQL < 9.0 (reverts 4c78976)
* Fix PostgreSQL nullable fields in export
* Fix table dependency on export
* Updating Russian translation
* Update haeckel design (thanks to Klemens Haeckel)
* PostgreSQL: Support JSON and JSONB data types (bug #542)
* PostgreSQL: Fix JSONB version support
* Don't overwrite previous cookies (bug #539)
* Add a todo
* Fix SQL command autofocus
* Release 4.3.1
* Add a donate link
* Update es.inc.php
* Sort table names (bug #552)
* MySQL: Remove dedicated view for replication status
* Update AdminerTablesFilter to produce li as per c9801e2
peterpp
added a commit
to pematon/adminer
that referenced
this pull request
Feb 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encapsulation of list items is necessary for advanced CSS themes.