-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Also check Answers
for records
#59
base: main
Are you sure you want to change the base?
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
if (_discovery != null) | ||
{ | ||
foreach (var profile in _profiles.Keys.ToArray()) | ||
Unadvertise(profile); | ||
|
||
_discovery.Dispose(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idk what these are, seems like Rider fixed the indentation but I don't see any difference. Maybe I'm blind
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I force-pushed and this time I edited by hand, this seems to be a git merge commit thing lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hiding whitespace hides these, if it's not indentation then it might be git modifying the line endings on account of weird git configuration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, you probably right. I'm in Linux and this repository probably uses LF only, right?
I have core.autocrlf=input
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$ file vrc-oscquery-lib/vrc-oscquery-lib/Zeroconf/ZeroconfTypes.cs
vrc-oscquery-lib/vrc-oscquery-lib/Zeroconf/ZeroconfTypes.cs: Unicode text, UTF-8 (with BOM) text, with CRLF line terminators
$ file vrc-oscquery-lib/vrc-oscquery-lib/Zeroconf/MeaModDiscovery.cs
vrc-oscquery-lib/vrc-oscquery-lib/Zeroconf/MeaModDiscovery.cs: Unicode text, UTF-8 (with BOM) text, with CRLF, LF line terminators
looks like it might not be standardized in the file anyways. Hmm...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, it should be solved in another PR. And probably added inside the .gitattributes
0e61b4a
to
39a34e5
Compare
Fixes #58