Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for ACM, Cloudwatch loggroup and flow_logs #5

Merged
merged 6 commits into from
May 12, 2023

Conversation

charugargtillster
Copy link

No description provided.

@charugargtillster
Copy link
Author

aws_eip.nat_eip-0
鈹斺攢 IP address (if unused) 730 hours $3.65

aws_eip.nat_eip-1
鈹斺攢 IP address (if unused) 730 hours $3.65

aws_eip.nat_eip-2
鈹斺攢 IP address (if unused) 730 hours $3.65

func GetACMCertificate() *schema.RegistryItem {
return &schema.RegistryItem{
Name: "states.aws.acm.certificate_manager.present",
RFunc: NewACMCertificate,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the .tf file there is certificate_authority_arn. How is it used?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the authority it calculates cost. So added the certificate_authority_arn in NewACMCertificate function

allocated = true
}

if !d.IsEmpty("customer_owned_ipv4_pool") || !d.IsEmpty("instance") || !d.IsEmpty("network_interface") {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see instance and network_interface in the idem-aws elastic_ip schema here: https://docs.idemproject.io/idem-aws/en/latest/ref/states/ec2/elastic_ip.html

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, Idem isn't supporting instance and network_interface at present. But anyway kept these variables in case we add support to these arguments.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a comment

@charugargtillster
Copy link
Author

eks_flow_log_group
鈹溾攢 Data ingested Monthly cost depends on usage: $0.55 per GB
鈹溾攢 Archival Storage Monthly cost depends on usage: $0.033 per GB
鈹斺攢 Insights queries data scanned Monthly cost depends on usage: $0.0055 per GB

@charugargtillster charugargtillster changed the title Added ACM and Cloudwatch loggroup Added support for ACM, Cloudwatch loggroup and flow_logs May 12, 2023
@vreutova vreutova merged commit 4c94d69 into vreutova:master May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants