-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for ACM, Cloudwatch loggroup and flow_logs #5
Conversation
aws_eip.nat_eip-0 aws_eip.nat_eip-1 aws_eip.nat_eip-2 |
func GetACMCertificate() *schema.RegistryItem { | ||
return &schema.RegistryItem{ | ||
Name: "states.aws.acm.certificate_manager.present", | ||
RFunc: NewACMCertificate, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the .tf file there is certificate_authority_arn. How is it used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the authority it calculates cost. So added the certificate_authority_arn in NewACMCertificate function
allocated = true | ||
} | ||
|
||
if !d.IsEmpty("customer_owned_ipv4_pool") || !d.IsEmpty("instance") || !d.IsEmpty("network_interface") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see instance and network_interface in the idem-aws elastic_ip schema here: https://docs.idemproject.io/idem-aws/en/latest/ref/states/ec2/elastic_ip.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, Idem isn't supporting instance and network_interface at present. But anyway kept these variables in case we add support to these arguments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a comment
eks_flow_log_group |
No description provided.