Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dataset filtering in parsing matomo events #2177

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

Zharktas
Copy link
Contributor

@Zharktas Zharktas commented Feb 5, 2024

All events were still being parsed, this should limit it to given dataset.

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b481436) 23.24% compared to head (903b64b) 18.00%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2177      +/-   ##
==========================================
- Coverage   23.24%   18.00%   -5.25%     
==========================================
  Files          42       29      -13     
  Lines        6052     5622     -430     
  Branches       35        0      -35     
==========================================
- Hits         1407     1012     -395     
+ Misses       4645     4610      -35     
Flag Coverage Δ
cdk ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Feb 5, 2024

Passing run #4703 ↗︎

0 85 3 0 Flakiness 0

Details:

Merge 903b64b into b7b121e...
Project: opendata Commit: 8274dfb6b0 ℹ️
Status: Passed Duration: 05:10 💡
Started: Feb 5, 2024 1:38 PM Ended: Feb 5, 2024 1:43 PM

Review all test suite changes for PR #2177 ↗︎

@Zharktas Zharktas merged commit 8700825 into master Feb 5, 2024
40 of 41 checks passed
@Zharktas Zharktas deleted the use_dataset_filtering_in_matomo_events branch February 5, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants