Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AV-2184: Add s3 dataset bucket to backup vault #2187

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

Zharktas
Copy link
Contributor

@Zharktas Zharktas commented Mar 1, 2024

S3 is not directly supported in cdk backup implementation, so it has to go through arn selection.

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.34%. Comparing base (acbdaa7) to head (a5a85ea).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2187      +/-   ##
==========================================
+ Coverage   23.27%   23.34%   +0.07%     
==========================================
  Files          42       42              
  Lines        6054     6060       +6     
  Branches       35       35              
==========================================
+ Hits         1409     1415       +6     
  Misses       4645     4645              
Flag Coverage Δ
cdk 92.00% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Zharktas Zharktas merged commit 0260427 into master Mar 4, 2024
20 of 21 checks passed
@Zharktas Zharktas deleted the AV-2184_add_s3_dataset_bucket_to_backup_vault branch March 4, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants