Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AV-972: Added alternative descriptions in matomo reports #2188

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

Zharktas
Copy link
Contributor

@Zharktas Zharktas commented Mar 5, 2024

Adds ability to add long descriptions and description templates in reports and adds them matomo reports with translation. If neither is given, the old description is shown.

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.34%. Comparing base (0260427) to head (0dcb22e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2188   +/-   ##
=======================================
  Coverage   23.34%   23.34%           
=======================================
  Files          42       42           
  Lines        6060     6060           
  Branches       35       35           
=======================================
  Hits         1415     1415           
  Misses       4645     4645           
Flag Coverage Δ
cdk 92.00% <ø> (ø)
ckan 18.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Zharktas Zharktas changed the title AV-972: Adds ability to have long descriptions and description templa… AV-972: Added alternative descriptions in matomo reports Mar 5, 2024
Copy link

cypress bot commented Mar 5, 2024

Passing run #4730 ↗︎

0 85 3 0 Flakiness 0

Details:

Merge 0dcb22e into 0260427...
Project: opendata Commit: 312cb82618 ℹ️
Status: Passed Duration: 06:03 💡
Started: Mar 5, 2024 12:32 PM Ended: Mar 5, 2024 12:38 PM

Review all test suite changes for PR #2188 ↗︎

@Zharktas Zharktas merged commit ab22808 into master Mar 5, 2024
40 of 41 checks passed
@Zharktas Zharktas deleted the AV-972_add_long_descriptions_and_templates branch March 5, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants