Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AV-2202: Fix server error in package_show api #2196

Merged
merged 3 commits into from
Mar 22, 2024

Conversation

Zharktas
Copy link
Contributor

There is a bug in ckan that doesn't handle boolean with parameter use_default_schema, it just uses default schema if the parameter exists in the api call.

Fixes the server error by removing schema from context on group_list call, as the schema in context is dataset schema which is totally wrong for group calls.

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.65%. Comparing base (44bd897) to head (df65bc0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2196      +/-   ##
==========================================
+ Coverage   23.28%   23.65%   +0.36%     
==========================================
  Files          42       42              
  Lines        6076     6088      +12     
  Branches       35       35              
==========================================
+ Hits         1415     1440      +25     
+ Misses       4661     4648      -13     
Flag Coverage Δ
cdk 92.04% <ø> (ø)
ckan 18.32% <100.00%> (+0.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Mar 22, 2024

Passing run #4762 ↗︎

0 85 3 0 Flakiness 0

Details:

Merge df65bc0 into 44bd897...
Project: opendata Commit: 70aef8dcd4 ℹ️
Status: Passed Duration: 05:55 💡
Started: Mar 22, 2024 12:26 PM Ended: Mar 22, 2024 12:32 PM

Review all test suite changes for PR #2196 ↗︎

@Zharktas Zharktas merged commit 56ded5b into master Mar 22, 2024
40 of 41 checks passed
@Zharktas Zharktas deleted the AV-2202_fix_server_error_in_api branch March 22, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants