[VRM10] VRM10Expression のカスタムエディターの修正 #1118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ousttrue
commented
Jul 29, 2021
ousttrue
commented
- Extract 時に Preview用のPrefab をセットする
- コード整理
- 未使用削除
- 一つしか継承しないので、継承やめ
- null check
- Preview用シーンの生成タイミングを遅延(prefabセット時ではなく、previewを使う直前)
* m_scene のライフサイクルを整理(生成を遅延。OnDestroyとPrefabが変更された時に破棄)
何故か null の時がある
ousttrue
commented
Jul 29, 2021
| @@ -8,26 +8,231 @@ | |||
| namespace UniVRM10 | |||
| { | |||
| [CustomEditor(typeof(VRM10Expression))] | |||
| public class ExpressionEditor : ExpressionEditorBase | |||
| public class ExpressionEditor : Editor | |||
There was a problem hiding this comment.
継承止め、 不要な protected, virtual, override, abstract を削除
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.