[1.0] FirstPerson 初期化を整理 #1206
Merged
[1.0] FirstPerson 初期化を整理 #1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Santarh
requested changes
Sep 9, 2021
| var count = ExcludeTriangles(indices, mesh.boneWeights, eraseBoneIndices); | ||
| var dst = new int[count]; | ||
| Array.Copy(indices, 0, dst, 0, count); | ||
| var dst = await awaitCaller.Run(() => GetExcludedIndices(src.GetIndices(i), mesh.boneWeights, eraseBoneIndices)); |
| public static Mesh CreateErasedMesh(Mesh src, int[] eraseBoneIndices) | ||
| { | ||
| var task = CreateErasedMeshAsync(src, eraseBoneIndices, new ImmediateCaller()); | ||
| task.Wait(); |
There was a problem hiding this comment.
ライブラリ内の ImmediateCaller を使っているから Wait しても大丈夫
| /// <param name="visible"></param> | ||
| /// <param name="awaitCaller"></param> | ||
| /// <returns></returns> | ||
| public async Task<List<SkinnedMeshRenderer>> SetupAsync(GameObject go, IAwaitCaller awaitCaller = null) |
There was a problem hiding this comment.
レイヤー設定、引数で渡せるようにした方がよさそう。
public static int を内部で参照するのはちょっとわかりづらい
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1194