Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[importer] 法線を保持するモデルで、不要な RecalculateNormals #1741

Merged
merged 4 commits into from Jul 19, 2022

Conversation

ousttrue
Copy link
Contributor

fixed #1740

見た目はつながっているが、ポリゴン構造上離れているようなモデルで RecalculateNormals すると、
隣り合わせの面の法線の連続性が無くなって顕在化しやすい。

@ousttrue ousttrue requested a review from notargs July 14, 2022 06:46
@ousttrue
Copy link
Contributor Author

法線を操作してあるタイプで、元に戻る

@ousttrue ousttrue added this to the v0.102 milestone Jul 14, 2022
@ousttrue ousttrue requested review from Santarh and removed request for notargs July 15, 2022 05:25
Copy link
Contributor

@Santarh Santarh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

なるほど

#if UNITY_EDITOR
using System.Runtime.CompilerServices;

[assembly: InternalsVisibleTo("UniGLTF.Tests")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good capsulized

@ousttrue ousttrue merged commit c3988f2 into vrm-c:master Jul 19, 2022
@ichi-23 ichi-23 mentioned this pull request Jul 22, 2022
@ousttrue ousttrue mentioned this pull request Jul 29, 2022
1 task
@ousttrue ousttrue deleted the fix/has_normal branch January 24, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The imported glTF model surface is not smooth
2 participants