arrays size must match mesh vertex count #1759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Santarh
approved these changes
Jul 29, 2022
| bs.Normals = new Vector3[Normals.Count]; | ||
| bs.Tangents = new Vector3[Tangents.Count]; | ||
| bs.Normals = new Vector3[Positions.Count]; | ||
| bs.Tangents = new Vector3[Positions.Count]; |
| // arrays size must match mesh vertex count | ||
| var positions = new Vector3[mesh.vertexCount]; | ||
| var normals = new Vector3[mesh.vertexCount]; | ||
| var tangents = new Vector3[mesh.vertexCount]; |
There was a problem hiding this comment.
これは… Clone() しなくなってるけど、下で GetBlendShapeFrameVertices してるから実は不要だった処理なので要らないで OK、かな？
There was a problem hiding this comment.
buffer として要素数のつじつまが合っていればよいらしい。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1746 の修正です。
v0.99.3にバックポート