[vrm1.0] impl remove scaling #2177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ousttrue
commented
Oct 25, 2023
| @@ -15,20 +15,20 @@ namespace UniGLTF.MeshUtility | |||
| /// UnityEngine.Object を継承したクラスのフィールドに ユーザー定義 struct を配置する。 | |||
| /// 持ち主の SerializedObject を経由して EditorGUILayout.PropertyField してる。 | |||
| /// </summary> | |||
| [CustomEditor(typeof(MeshProcessDialog), true)] | |||
There was a problem hiding this comment.
gltf の meshutility を rename。中身は変えていない
ousttrue
commented
Oct 25, 2023
| @@ -10,7 +10,6 @@ namespace UniGLTF | |||
| public static class TopMenu | |||
| { | |||
| private const string UserGltfMenuPrefix = UniGLTFVersion.MENU; | |||
| private const string UserMeshUtilityPrefix = UniGLTFVersion.MENU + "/Mesh Utility"; | |||
| private const string DevelopmentMenuPrefix = UniGLTFVersion.MENU + "/Development"; | |||
There was a problem hiding this comment.
Menu が深かったので浅くしてみた
ousttrue
commented
Oct 25, 2023
| static (GameObject, Dictionary<Transform, Transform>) NormalizeHierarchy(GameObject go, CreateAvatarFunc createAvatar) | ||
| public static (GameObject, Dictionary<Transform, Transform>) CreateNormalizedHierarchy(GameObject go, | ||
| bool removeScaling = true, | ||
| bool removeRotation = true) |
There was a problem hiding this comment.
新機能。ヒエラルキーからの Scale/Rotation の除去を
Scale だけの除去ができるように追加した。
ousttrue
commented
Oct 25, 2023
| @@ -271,5 +272,42 @@ public static bool GetHumanDescription(UnityEngine.Object target, ref HumanDescr | |||
| return false; | |||
| } | |||
| #endif | |||
|
|
|||
There was a problem hiding this comment.
コールバックで渡していた定型処理を関数化
ousttrue
commented
Oct 25, 2023
| @@ -0,0 +1,96 @@ | |||
| using System.Collections.Generic; | |||
There was a problem hiding this comment.
新規。vrm1 mesh utlity ダイアログ
ousttrue
commented
Oct 25, 2023
| using UniHumanoid; | ||
| using UnityEngine; | ||
|
|
||
| namespace UniVRM10 |
There was a problem hiding this comment.
新規。vrm1 mesh utility のロジック。
なるべく Runtime、
なるべく Gltf層、
というように後で整理して共通化する予定。
Santarh
approved these changes
Oct 25, 2023
| @@ -271,5 +272,42 @@ public static bool GetHumanDescription(UnityEngine.Object target, ref HumanDescr | |||
| return false; | |||
| } | |||
| #endif | |||
|
|
|||
| public static void AddAnimator(GameObject _src, | |||
There was a problem hiding this comment.
やってる内容としては CreateAvatarAndAddAnimatorComponent ってところかな。
Avatar は Animator とは無関係に作れるので、その処理は
Avatrar CreateAvatar(~~~)
として関数分けておいた方が読みやすいかもしれません。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2169 の部品。
という作業順を予定。
freeze => integrate => split というパイプラインを予定しています。
freeze の一部としてヒエラルキーからの scale/rotation 除去を実装しました。
vrm0 の該当部分とコードを共有しました。