Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vrm1.0] impl refactor mesh bake #2179

Merged
merged 4 commits into from
Oct 27, 2023

Conversation

ousttrue
Copy link
Contributor

#2169 の部品

vrm-0 の正規化ロジックを公開関数にしてオプションを整理。
ロジックの変更はまだしていない。
mesh bake までできるようになった。

using System.Linq;
using UnityEngine;

namespace UniGLTF.MeshUtility
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ファイル分割

Copy link
Contributor

@Santarh Santarh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

できあがるまではとりあえず Approve

なるべくエントリポイント(ユーザが呼び出すところ)以外は public にはしたくないですね

@ousttrue ousttrue merged commit 897d6c7 into vrm-c:master Oct 27, 2023
1 check passed
@ousttrue ousttrue deleted the fix/impl_refactor_mesh_bake branch January 24, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants