Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vrm10] SpringBone の inspector 修正など #2253

Merged

Conversation

ousttrue
Copy link
Contributor

@ousttrue ousttrue commented Feb 27, 2024

ちょっと見やすくなった

@ousttrue ousttrue added this to the v0.120 milestone Feb 27, 2024
var i = spring.Joints[0].Node.Value;
if (i >= 0 && i < _gltf.nodes.Count)
{
spring.Name = _gltf.nodes[i].name;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

無名のとき node の名前を拾う

if (i >= 0 && i < gltf.nodes.Count)
{
var node = gltf.nodes[i];
colliderGroup.Name = node.name;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

無名のとき node の名前を拾う

@@ -554,6 +554,7 @@ async Task LoadSpringBoneAsync(IAwaitCaller awaitCaller, Vrm10Instance controlle
foreach (var g in gltfVrmSpringBone.ColliderGroups)
{
var colliderGroup = secondary.gameObject.AddComponent<VRM10SpringBoneColliderGroup>();
colliderGroup.Name = g.Name;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import 漏れ


namespace UniVRM10
{
[CustomPropertyDrawer(typeof(VRM10SpringBoneColliderGroup))]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

list の elment 0 表示を変える

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@Santarh Santarh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ousttrue ousttrue merged commit dad8305 into vrm-c:master Feb 27, 2024
1 check passed
@ousttrue ousttrue deleted the fix/vrm10_springbone_inspector_migration branch February 27, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants