-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vrm10] SpringBone の inspector 修正など #2253
[vrm10] SpringBone の inspector 修正など #2253
Conversation
var i = spring.Joints[0].Node.Value; | ||
if (i >= 0 && i < _gltf.nodes.Count) | ||
{ | ||
spring.Name = _gltf.nodes[i].name; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
無名のとき node の名前を拾う
if (i >= 0 && i < gltf.nodes.Count) | ||
{ | ||
var node = gltf.nodes[i]; | ||
colliderGroup.Name = node.name; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
無名のとき node の名前を拾う
@@ -554,6 +554,7 @@ async Task LoadSpringBoneAsync(IAwaitCaller awaitCaller, Vrm10Instance controlle | |||
foreach (var g in gltfVrmSpringBone.ColliderGroups) | |||
{ | |||
var colliderGroup = secondary.gameObject.AddComponent<VRM10SpringBoneColliderGroup>(); | |||
colliderGroup.Name = g.Name; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import 漏れ
|
||
namespace UniVRM10 | ||
{ | ||
[CustomPropertyDrawer(typeof(VRM10SpringBoneColliderGroup))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
list の elment 0
表示を変える
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ちょっと見やすくなった