Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix export test #359

Merged
merged 2 commits into from
Dec 26, 2019
Merged

fix export test #359

merged 2 commits into from
Dec 26, 2019

Conversation

hiroj
Copy link
Contributor

@hiroj hiroj commented Dec 26, 2019

#357
add null check

@hiroj hiroj requested a review from ousttrue December 26, 2019 08:53
@saturday06
Copy link
Contributor

gltf/meshes[]/primitives[]/targets に関しても同様のnullチェックが必要かもしれません

@hiroj
Copy link
Contributor Author

hiroj commented Dec 26, 2019

targetのnullチェック追加しました

@saturday06
Copy link
Contributor

対応ありがとうございます！

@ousttrue ousttrue merged commit 5fd456b into vrm-c:master Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ousttrue ousttrue ousttrue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hiroj @saturday06 @ousttrue