Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use the variadic max to avoid gc #862

Merged
merged 1 commit into from
Apr 12, 2021
Merged

Do not use the variadic max to avoid gc #862

merged 1 commit into from
Apr 12, 2021

Conversation

ousttrue
Copy link
Contributor

public static float Max(params float[] values);

#843

@ousttrue
Do not use the variadic max to avoid gc
4893c4b 
public static float Max(params float[] values);
@ousttrue ousttrue requested a review from Santarh April 12, 2021 07:27
@ousttrue ousttrue added this to the v0.72 milestone Apr 12, 2021
@ousttrue ousttrue merged commit f388406 into vrm-c:master Apr 12, 2021
@Santarh
Copy link
Contributor

Santarh commented Apr 12, 2021

むしろ UnityEngine.Mathf.Max って 3 以上の引数をとるオーバーロードあったんだ！
✔️

@ousttrue ousttrue deleted the fix/max_variadic_argument_gc branch May 17, 2021 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Santarh Santarh Awaiting requested review from Santarh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.72
Development

Successfully merging this pull request may close these issues.
2 participants
@ousttrue @Santarh