fix MagFiler #945
Merged
fix MagFiler #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Santarh
reviewed
May 14, 2021
| @@ -33,6 +33,9 @@ public void Push(Vector3 position, Vector3 normal) | |||
| public gltfMorphTarget ToGltf(glTF gltf, int bufferIndex, bool useNormal) | |||
| { | |||
| var positionAccessorIndex = gltf.ExtendBufferAndGetAccessorIndex(bufferIndex, m_positions.ToArray(), glBufferTarget.ARRAY_BUFFER); | |||
| gltf.accessors[positionAccessorIndex].min = m_positions.Aggregate(m_positions[0], (a, b) => new Vector3(Mathf.Min(a.x, b.x), Math.Min(a.y, b.y), Mathf.Min(a.z, b.z))).ToArray(); | |||
| gltf.accessors[positionAccessorIndex].max = m_positions.Aggregate(m_positions[0], (a, b) => new Vector3(Mathf.Max(a.x, b.x), Math.Max(a.y, b.y), Mathf.Max(a.z, b.z))).ToArray(); | |||
Santarh
approved these changes
May 14, 2021
| @@ -8,7 +8,24 @@ namespace UniGLTF | |||
| public static class TextureSamplerUtil | |||
| { | |||
| #region Export | |||
| public static glFilter ExportFilterMode(Texture texture) | |||
| // MagFilter は ２種類だけ | |||
| public static glFilter ExportMagFilter(Texture texture) | |||
| } | ||
| } | ||
|
|
||
| public static glFilter ExportMinFilter(Texture texture) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#943