Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make it IE compatible #1

Merged
merged 2 commits into from
Dec 7, 2018
Merged

make it IE compatible #1

merged 2 commits into from
Dec 7, 2018

Conversation

wingleung
Copy link
Member

Small tweaks to make it IE11 compatible.
Should be refactored to use plain JS and better frontend setup later on.

@wingleung wingleung mentioned this pull request Dec 7, 2018
Closed
@nielslaukens
Copy link
Contributor

This won't work. The index.html file is served by a Lambda, not by a regular web server. Therefore, the .js and .css URL will return 404, since there is no matching path defined in the API gateway.

@wingleung
Copy link
Member Author

wingleung commented Dec 7, 2018 •
edited
Loading

@nielslaukens Thanks for reviewing, we definitely need a more elegant frontend setup then.
For now, moved scripts and styling back to index.html

@nielslaukens nielslaukens merged commit 65a7a4a into vrtdev:master Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielslaukens nielslaukens nielslaukens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wingleung @nielslaukens