Version 2.1.6 causes crash when VSCommands or Red Gate's SQL Prompt installed. #150

Closed
bryansoto opened this Issue Mar 3, 2014 · 11 comments

Comments

Projects
None yet
2 participants
@bryansoto

Having VSCommands 12.3.0.5 (free version) or Red Gates SQL Prompt 6.2.0.366 (trial) installed at the same time as VSClojure results in Visual Studio crashing right after asking to display the README file.

This occurs in both VS 2012 & 2013 Professional editions, though I only narrowed down the extensions in 2013. I'm running 64-bit Windows 8.1.

I had the previous version of VSClojure installed and didn't have this problem.

vs crash

@frankhale

This comment has been minimized.

Show comment Hide comment
@frankhale

frankhale Mar 3, 2014

Contributor

Thanks Bryan for the report! Interestingly enough I just installed VSCommands 12.3.0.5 and just installed vsClojure 2.1.6 from the VS Gallery and I am not seeing a crash. I'm on VS2013 Ultimate, Windows 8.1 x64. Is there anything else I can do in order to reproduce this?

Contributor

frankhale commented Mar 3, 2014

Thanks Bryan for the report! Interestingly enough I just installed VSCommands 12.3.0.5 and just installed vsClojure 2.1.6 from the VS Gallery and I am not seeing a crash. I'm on VS2013 Ultimate, Windows 8.1 x64. Is there anything else I can do in order to reproduce this?

@bryansoto

This comment has been minimized.

Show comment Hide comment
@bryansoto

bryansoto Mar 3, 2014

Not that I'm aware of. I must have trashed my setup then. I'll try duplicating in a clean profile though now I expect it will work just fine. Probably should have tried that first... Oh well.

Sorry for the noise.

Not that I'm aware of. I must have trashed my setup then. I'll try duplicating in a clean profile though now I expect it will work just fine. Probably should have tried that first... Oh well.

Sorry for the noise.

@bryansoto bryansoto closed this Mar 3, 2014

@frankhale

This comment has been minimized.

Show comment Hide comment
@frankhale

frankhale Mar 3, 2014

Contributor

Oh, there may well be a bug that we are not aware of. I'd like to see what
happens when you try it again on a clean profile.

On Mon, Mar 3, 2014 at 3:34 PM, Bryan Soto notifications@github.com wrote:

Closed #150 #150.

Reply to this email directly or view it on GitHubhttps://github.com/vsClojure/vsClojure/issues/150
.

Contributor

frankhale commented Mar 3, 2014

Oh, there may well be a bug that we are not aware of. I'd like to see what
happens when you try it again on a clean profile.

On Mon, Mar 3, 2014 at 3:34 PM, Bryan Soto notifications@github.com wrote:

Closed #150 #150.

Reply to this email directly or view it on GitHubhttps://github.com/vsClojure/vsClojure/issues/150
.

@bryansoto

This comment has been minimized.

Show comment Hide comment
@bryansoto

bryansoto Mar 3, 2014

Funny you ask. SQL Prompt is a separate download and install, so it was already registered in my clean profile. As soon as I restarted after installing VSClojure, I had the crash again.

Funny you ask. SQL Prompt is a separate download and install, so it was already registered in my clean profile. As soon as I restarted after installing VSClojure, I had the crash again.

@frankhale

This comment has been minimized.

Show comment Hide comment
@frankhale

frankhale Mar 3, 2014

Contributor

So the extension that may be exposing this may be the SQL prompt. I haven't
tried that one yet.

On Mon, Mar 3, 2014 at 4:43 PM, Bryan Soto notifications@github.com wrote:

Funny you ask. SQL Prompt is a separate download and install, so it was
already registered in my clean profile. As soon as I restarted after
installing VSClojure, I had the crash again.

Reply to this email directly or view it on GitHubhttps://github.com/vsClojure/vsClojure/issues/150#issuecomment-36563650
.

Contributor

frankhale commented Mar 3, 2014

So the extension that may be exposing this may be the SQL prompt. I haven't
tried that one yet.

On Mon, Mar 3, 2014 at 4:43 PM, Bryan Soto notifications@github.com wrote:

Funny you ask. SQL Prompt is a separate download and install, so it was
already registered in my clean profile. As soon as I restarted after
installing VSClojure, I had the crash again.

Reply to this email directly or view it on GitHubhttps://github.com/vsClojure/vsClojure/issues/150#issuecomment-36563650
.

@bryansoto

This comment has been minimized.

Show comment Hide comment
@bryansoto

bryansoto Mar 3, 2014

For me, it was both... I went through one by and the crash occurred with either of them.

For me, it was both... I went through one by and the crash occurred with either of them.

@frankhale

This comment has been minimized.

Show comment Hide comment
@frankhale

frankhale Mar 3, 2014

Contributor

Ok. Will you reopen the issue?

On Mon, Mar 3, 2014 at 5:08 PM, Bryan Soto notifications@github.com wrote:

For me, it was both... I went through one by and the crash occurred with
either of them.

Reply to this email directly or view it on GitHubhttps://github.com/vsClojure/vsClojure/issues/150#issuecomment-36566468
.

Contributor

frankhale commented Mar 3, 2014

Ok. Will you reopen the issue?

On Mon, Mar 3, 2014 at 5:08 PM, Bryan Soto notifications@github.com wrote:

For me, it was both... I went through one by and the crash occurred with
either of them.

Reply to this email directly or view it on GitHubhttps://github.com/vsClojure/vsClojure/issues/150#issuecomment-36566468
.

@bryansoto bryansoto reopened this Mar 3, 2014

@bryansoto

This comment has been minimized.

Show comment Hide comment
@bryansoto

bryansoto Mar 25, 2014

It's a stack overflow. Link to call stack: https://gist.github.com/bryansoto/9767628

It's a stack overflow. Link to call stack: https://gist.github.com/bryansoto/9767628

@frankhale

This comment has been minimized.

Show comment Hide comment
@frankhale

frankhale Mar 25, 2014

Contributor

Thanks. I've looked it over but I'm not sure this is going to help any. There isn't much information in there that would point to what is going on.

Contributor

frankhale commented Mar 25, 2014

Thanks. I've looked it over but I'm not sure this is going to help any. There isn't much information in there that would point to what is going on.

@bryansoto

This comment has been minimized.

Show comment Hide comment
@bryansoto

bryansoto Mar 27, 2014

Sorry for the delay in getting back to you. My family had a medical emergency.

Clojure hooks OnAssemblyResolve and calls GetManifestResourceStream. SqlPrompt hooks OnResourceResolve, which GetManifestResourceStream invokes, and calls Assembly.Load which invokes OnAssemblyResolve repeating until the stack is blown.

Since it looks like you just package clojure-clr and the code in question is part of that project's runtime code, I don't think this is a VSClojure issue. If you have no objections, why don't we close this ticket.

Sorry for the delay in getting back to you. My family had a medical emergency.

Clojure hooks OnAssemblyResolve and calls GetManifestResourceStream. SqlPrompt hooks OnResourceResolve, which GetManifestResourceStream invokes, and calls Assembly.Load which invokes OnAssemblyResolve repeating until the stack is blown.

Since it looks like you just package clojure-clr and the code in question is part of that project's runtime code, I don't think this is a VSClojure issue. If you have no objections, why don't we close this ticket.

@frankhale

This comment has been minimized.

Show comment Hide comment
@frankhale

frankhale Mar 27, 2014

Contributor

Thanks for the explanation. I'll close it.

Contributor

frankhale commented Mar 27, 2014

Thanks for the explanation. I'll close it.

@frankhale frankhale closed this Mar 27, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment