Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for vscode prior of version 1.8.1. #1071

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ environment:
# Define versions of Node.js
matrix:
- node_js: ''
- node_js: 7.4.0 # vscode 1.13.-insiders
- node_js: 6 # vscode > 1.6.1
- node_js: 6.5.0 # vscode 1.6.1
- node_js: 7.4.0 # vscode latest insiders
- node_js: 6 # vscode > 1.8.1
- node_js: 6.5.0 # vscode 1.8.1
matrix:
fast_finish: true
allow_failures:
Expand Down
4 changes: 2 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ os:
node_js:
- node # latest node
- 7.4.0 # vscode latest insiders
- 6 # vscode > 1.6.1
- 6.5.0 # vscode 1.6.1
- 6 # vscode > 1.8.1
- 6.5.0 # vscode 1.8.1
matrix:
allow_failures:
- node_js: node
Expand Down
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@
[![Average time to resolve an issue](https://isitmaintained.com/badge/resolution/vscode-icons/vscode-icons.svg)](https://isitmaintained.com/project/vscode-icons/vscode-icons "Average time to resolve an issue")
[![Percentage of issues still open](https://isitmaintained.com/badge/open/vscode-icons/vscode-icons.svg)](https://isitmaintained.com/project/vscode-icons/vscode-icons "Percentage of issues still open")


Bring icons to your VS Code.
Bring icons to your [Visual Studio Code](https://code.visualstudio.com/) (**minimum supported version: `1.8.1`**)

![demo](https://raw.githubusercontent.com/vscode-icons/vscode-icons/master/images/screenshot.gif)

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"email": "roberto.huertas@outlook.com"
},
"engines": {
"vscode": "^1.6.1",
"vscode": "^1.8.1",
"node": ">=6.5.0"
},
"categories": [
Expand Down
1 change: 0 additions & 1 deletion src/vscode.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,5 @@ import { IVSIcons } from './models/contributions';
declare module 'vscode' {
interface WorkspaceConfiguration {
vsicons: IVSIcons;
inspect<T>(section: string): {defaultValue: T, globalValue: T, key: string, workspaceValue: T} | undefined;
}
}