added support for stylable #1426

tomrav · 2018-01-24T20:00:38Z

Changes proposed:
Add icon and configuration for stylable css files using the .st.css suffix.

Add
Delete
Fix
Prepare

jens1o

lgtm. Thanks for your contribution.

JimiC · 2018-01-25T08:30:55Z

src/icon-manifest/supportedExtensions.ts

@@ -476,6 +476,7 @@ export const extensions: IFileCollection = {
      filename: true,
      format: FileFormat.svg,
    },
+    { icon: 'stylable', extensions: ['.st.css'], languages: [languages.stylable], light: true, format: FileFormat.svg },


Please remove light attribute. This is used if there are different icons for dark and light themes.

JimiC · 2018-01-25T09:28:18Z

src/icon-manifest/supportedExtensions.ts

@@ -476,6 +476,7 @@ export const extensions: IFileCollection = {
      filename: true,
      format: FileFormat.svg,
    },
+    { icon: 'stylable', extensions: ['.st.css'], languages: [languages.stylable], format: FileFormat.svg },


Also, remove the .st.css from the extensions attribute. Using language id ensures that whatever extensions are specified in the vscode stylable extension will be used. And in this case this extension has it defined @ https://github.com/wix/stylable-intelligence/blob/master/packages/client/package.json#L33

Just to make sure I understood, by using our language-intelligence extension, and allowing it to determine the language of the file - vscode-icons will mark files with the Stylable icon on any file determined to be a Stylable stylesheet (by said language-intelligence)?

Yes. The icon will lit as soon as the extension get's installed on vscode. And any file extension defined in the 3rd party extension will be automatically supported and associated. That's the power of the language id.

JimiC · 2018-01-25T10:00:39Z

@tomrav Never mind.

codecov · 2018-01-25T10:06:19Z

Codecov Report

Merging #1426 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1426   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          48      48           
  Lines        2621    2621           
  Branches      134     134           
======================================
  Hits         2621    2621

Impacted Files	Coverage Δ
src/icon-manifest/supportedExtensions.ts	`100% <ø> (ø)`	⬆️
src/icon-manifest/languages.ts	`100% <ø> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a715cb4...76dabe9. Read the comment docs.

JimiC · 2018-01-25T10:08:20Z

@tomrav I pushed changes to the icon to comply with our art guidelines (we haven't fully documented them yet so don't try to look them up).

tomrav · 2018-01-25T10:09:33Z

Thanks for the help! 👍

* Update vscode icon to new color (blue). (#1288) * Add `.prettierignore` to prettier icon (#1339) closes #1338 * Extend Storybook supported extensions. (#1343) * Add ability to hide folder arrows in explorer. (#1342) * Translations (#1344) * New translations package.nls.json (Chinese Simplified) * New translations lang.en.json (Chinese Simplified) * New translations package.nls.json (Spanish) * New translations lang.en.json (Spanish) * New translations package.nls.json (German) * New translations lang.en.json (German) * New translations lang.en.json (Italian) * New translations package.nls.json (Italian) * New translations lang.en.json (Russian) * New translations package.nls.json (Russian) * New translations lang.en.json (French) * New translations package.nls.json (French) * Update README.md: Docs (#1351) * Next release (#1352) * preparing 7.18.0 * Make some entries more descriptive. * latest additions * version bump * Adds webpack.prod.conf.js support (#1357) * New Crowdin translations (#1355) * New translations package.nls.json (Japanese) * New translations lang.en.json (Japanese) * New translations package.nls.json (Japanese) * New translations package.nls.json (Japanese) * New translations lang.en.json (Japanese) * Map `screenshot(s)?` to `image` folder icon (#1362) * Replace GitHub Emoji of right arrow. (#1360) It doesn't render in `vscode` marketplace. * Update Yarn version in CI. (#1359) * Add wiki page icons list generator as submodule. (#1366) * Add wiki page icons list generator as submodule. * Update wpilgenerator. * Added .stylelintcache (#1369) * Add examples generator tool as submodule. (#1370) * support for cargo (#1371) * Update submodule wpilgenerator. (#1372) * Add support for pip. (#1373) * Add support for Cypress. (#1374) * Add support for Bazel. (#1375) * Add support for Kivy. (#1376) * Update submodule wpilgenerator. (#1380) * Update submodule wpilgenerator. (#1386) * Update wpilgenerator to v0.1.1. (#1388) * Add support for Conan. (#1390) * Add support for Stata. (#1389) * Update submodule examples-generator (#1387) * Add new extensions for tsconfig (#1384) * [Icon Request] tsconfig new extensions #1379 relates to: #1379 * remove trailing * Add support for more folder names. (#1383) * Exclude specific folders and files from distribution. (#1382) * Add script to initialize submodules. (#1393) * Update dependencies. (#1394) * Preparing 7.19.0 (#1399) * preparing next release * coffee typo * version bump * Update wpilgenerator to v0.2.0. (#1401) * support for jsonc (#1403) * support for jsonc * fix duplicated language id * Improve GitHub templates. (#1381) * Improve GitHub templates. Update wpilgenerator to v0.1.1. (#1388) Add support for Conan. (#1390) Add support for Stata. (#1389) Update submodule examples-generator (#1387) Add new extensions for tsconfig (#1384) * [Icon Request] tsconfig new extensions #1379 relates to: #1379 * remove trailing Add support for more folder names. (#1383) Exclude specific folders and files from distribution. (#1382) Add script to initialize submodules. (#1393) Update dependencies. (#1394) Merge branch 'master' into improve_templates Move comments to wiki. * Fix links to wiki pages. * Fix typo. * Add support for Jupyter. (#1409) * Add support for PhraseApp. (#1410) * Add support for Django. (#1411) * Add support for NGINX. (#1412) * add solidarity file type and icon (#1413) * add solidarity file type and icon * Apply art guidelines. * Add proper support for Elixir templates. (#1419) * Fix PAD icon disabled matcher. (#1421) * Add support to specify a relative path for custom icons folder path. (#1422) * Update dependencies. (#1423) * Fix errors when debugging test cases. (#1424) * added support for stylable (#1426) * added support for stylable * remove light attribute for stylable * removed stylable file extension definition * Change icon to comply to art guidelines. * fixed docker scripts (#1432) * Use bundler icon for files with .gemfile extension (#1430) * Add support for rubocop (#1436) * Add support for rubocop * Adjust icons to art guidelines. * Add support for tslint.yaml & tslint.yml (#1438) * #1434 Support for tsconfig.yaml and tsconfig.yml * Fixed tslint * Removed yaml extension for tsconfig * Add "asm" id to assembly. (#1450) * Remove "yml" file extension declaration. (#1451) This file extension is already supported natively from the editor. * Add support for docker test filename. (#1452) * Add support for SystemVerilog. (#1453) * Add support for Verilog. (#1454) * Fix rejection handling of "findFiles". (#1463) * Add vscode-icons-js to related (#1464) * Update dependencies. (#1467) * README fix link: Customization, not Configuration (#1448) * README fie link: Customization, not Configuration * Correcting typo link. * Fix package managers lock files. (#1468) * 7.20.0 (#1466) * 7.20.0 * 1464 added * Update CHANGELOG. * version bump * Typo?

added support for stylable

01bdc1f

jens1o previously approved these changes Jan 24, 2018

View reviewed changes

JimiC requested changes Jan 25, 2018

View reviewed changes

remove light attribute for stylable

0dc1a65

tomrav dismissed jens1o’s stale review via 0dc1a65 January 25, 2018 09:08

JimiC requested changes Jan 25, 2018

View reviewed changes

removed stylable file extension definition

9785738

Change icon to comply to art guidelines.

76dabe9

JimiC approved these changes Jan 25, 2018

View reviewed changes

jens1o approved these changes Jan 25, 2018

View reviewed changes

robertohuertasm approved these changes Jan 27, 2018

View reviewed changes

robertohuertasm merged commit c9080d1 into vscode-icons:master Jan 27, 2018

robertohuertasm added this to the Next milestone Jan 28, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added support for stylable #1426

added support for stylable #1426

tomrav commented Jan 24, 2018 •

edited

Loading

jens1o left a comment

JimiC Jan 25, 2018

tomrav Jan 25, 2018

JimiC Jan 25, 2018

tomrav Jan 25, 2018

JimiC Jan 25, 2018 •

edited

Loading

JimiC commented Jan 25, 2018 •

edited

Loading

codecov bot commented Jan 25, 2018 •

edited

Loading

JimiC commented Jan 25, 2018 •

edited

Loading

tomrav commented Jan 25, 2018

added support for stylable #1426

added support for stylable #1426

Conversation

tomrav commented Jan 24, 2018 • edited Loading

jens1o left a comment

Choose a reason for hiding this comment

JimiC Jan 25, 2018

Choose a reason for hiding this comment

tomrav Jan 25, 2018

Choose a reason for hiding this comment

JimiC Jan 25, 2018

Choose a reason for hiding this comment

tomrav Jan 25, 2018

Choose a reason for hiding this comment

JimiC Jan 25, 2018 • edited Loading

Choose a reason for hiding this comment

JimiC commented Jan 25, 2018 • edited Loading

codecov bot commented Jan 25, 2018 • edited Loading

Codecov Report

JimiC commented Jan 25, 2018 • edited Loading

tomrav commented Jan 25, 2018

tomrav commented Jan 24, 2018 •

edited

Loading

JimiC Jan 25, 2018 •

edited

Loading

JimiC commented Jan 25, 2018 •

edited

Loading

codecov bot commented Jan 25, 2018 •

edited

Loading

JimiC commented Jan 25, 2018 •

edited

Loading