Improve GitHub templates. #1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimiC
force-pushed
the
improve_templates
branch
from
1e887a1
to
c4dacb2
Compare
Codecov Report
@@ Coverage Diff @@
## master #1381 +/- ##
======================================
Coverage 100% 100%
======================================
Files 48 48
Lines 2571 2571
Branches 129 129
======================================
Hits 2571 2571Continue to review full report at Codecov.
|
jens1o
reviewed
Nov 25, 2017
.github/CONTRIBUTING.md
Outdated
| 1. Include screenshots or GIFs whenever possible. | ||
| 1. Don't be rude, describe your problem cool. | ||
|
|
||
| **Pull Request:** | ||
|
|
||
| 1. Use the present tense. | ||
| 1. Use the present tense in your commit message. | ||
| 1. Fill in the provided pull request template**. |
There was a problem hiding this comment.
what does ** at the end refer to?
There was a problem hiding this comment.
Copy-paste leftover. Nice catch.
JimiC
force-pushed
the
improve_templates
branch
2 times, most recently
from
5ddbdce
to
af2bea9
Compare
|
@JimiC I think you should remove example comment in issues templstes to contributing. Do you think that? |
|
@torn4dom4n My opinion is that all this info inside the templates should be moved to the wiki and templates should only contain the scaffold plus the link to the wiki page. |
|
It is a good idea! |
|
I agree with you @JimiC 👍 |
|
Are you willing to make the move before next release? Although, this is not affecting the deliverable so... no hurries! |
Update wpilgenerator to v0.1.1. (vscode-icons#1388) Add support for Conan. (vscode-icons#1390) Add support for Stata. (vscode-icons#1389) Update submodule examples-generator (vscode-icons#1387) Add new extensions for tsconfig (vscode-icons#1384) * [Icon Request] tsconfig new extensions vscode-icons#1379 relates to: vscode-icons#1379 * remove trailing Add support for more folder names. (vscode-icons#1383) Exclude specific folders and files from distribution. (vscode-icons#1382) Add script to initialize submodules. (vscode-icons#1393) Update dependencies. (vscode-icons#1394) Merge branch 'master' into improve_templates Move comments to wiki.
JimiC
force-pushed
the
improve_templates
branch
from
62d9a25
to
4bedc91
Compare
|
Wiki pages have been added. |
jens1o
reviewed
Dec 17, 2017
README.md
Outdated
| @@ -81,6 +81,8 @@ For those using [Docker](https://www.docker.com/) checkout the [docker section]( | |||
|
|
|||
| On the other hand, if you want to show the world your artistic side, checkout the [contributing section](https://github.com/vscode-icons/vscode-icons/wiki/Contributing). | |||
|
|
|||
| On any case, please follow our [contribution guidelines](https://github.com/vscode-icons/vscode-icons/blob/master/.github/CONTRIBUTING.md). | |||
robertohuertasm
approved these changes
Dec 30, 2017
robertohuertasm
pushed a commit
that referenced
this pull request
Feb 26, 2018
* Update vscode icon to new color (blue). (#1288) * Add `.prettierignore` to prettier icon (#1339) closes #1338 * Extend Storybook supported extensions. (#1343) * Add ability to hide folder arrows in explorer. (#1342) * Translations (#1344) * New translations package.nls.json (Chinese Simplified) * New translations lang.en.json (Chinese Simplified) * New translations package.nls.json (Spanish) * New translations lang.en.json (Spanish) * New translations package.nls.json (German) * New translations lang.en.json (German) * New translations lang.en.json (Italian) * New translations package.nls.json (Italian) * New translations lang.en.json (Russian) * New translations package.nls.json (Russian) * New translations lang.en.json (French) * New translations package.nls.json (French) * Update README.md: Docs (#1351) * Next release (#1352) * preparing 7.18.0 * Make some entries more descriptive. * latest additions * version bump * Adds webpack.prod.conf.js support (#1357) * New Crowdin translations (#1355) * New translations package.nls.json (Japanese) * New translations lang.en.json (Japanese) * New translations package.nls.json (Japanese) * New translations package.nls.json (Japanese) * New translations lang.en.json (Japanese) * Map `screenshot(s)?` to `image` folder icon (#1362) * Replace GitHub Emoji of right arrow. (#1360) It doesn't render in `vscode` marketplace. * Update Yarn version in CI. (#1359) * Add wiki page icons list generator as submodule. (#1366) * Add wiki page icons list generator as submodule. * Update wpilgenerator. * Added .stylelintcache (#1369) * Add examples generator tool as submodule. (#1370) * support for cargo (#1371) * Update submodule wpilgenerator. (#1372) * Add support for pip. (#1373) * Add support for Cypress. (#1374) * Add support for Bazel. (#1375) * Add support for Kivy. (#1376) * Update submodule wpilgenerator. (#1380) * Update submodule wpilgenerator. (#1386) * Update wpilgenerator to v0.1.1. (#1388) * Add support for Conan. (#1390) * Add support for Stata. (#1389) * Update submodule examples-generator (#1387) * Add new extensions for tsconfig (#1384) * [Icon Request] tsconfig new extensions #1379 relates to: #1379 * remove trailing * Add support for more folder names. (#1383) * Exclude specific folders and files from distribution. (#1382) * Add script to initialize submodules. (#1393) * Update dependencies. (#1394) * Preparing 7.19.0 (#1399) * preparing next release * coffee typo * version bump * Update wpilgenerator to v0.2.0. (#1401) * support for jsonc (#1403) * support for jsonc * fix duplicated language id * Improve GitHub templates. (#1381) * Improve GitHub templates. Update wpilgenerator to v0.1.1. (#1388) Add support for Conan. (#1390) Add support for Stata. (#1389) Update submodule examples-generator (#1387) Add new extensions for tsconfig (#1384) * [Icon Request] tsconfig new extensions #1379 relates to: #1379 * remove trailing Add support for more folder names. (#1383) Exclude specific folders and files from distribution. (#1382) Add script to initialize submodules. (#1393) Update dependencies. (#1394) Merge branch 'master' into improve_templates Move comments to wiki. * Fix links to wiki pages. * Fix typo. * Add support for Jupyter. (#1409) * Add support for PhraseApp. (#1410) * Add support for Django. (#1411) * Add support for NGINX. (#1412) * add solidarity file type and icon (#1413) * add solidarity file type and icon * Apply art guidelines. * Add proper support for Elixir templates. (#1419) * Fix PAD icon disabled matcher. (#1421) * Add support to specify a relative path for custom icons folder path. (#1422) * Update dependencies. (#1423) * Fix errors when debugging test cases. (#1424) * added support for stylable (#1426) * added support for stylable * remove light attribute for stylable * removed stylable file extension definition * Change icon to comply to art guidelines. * fixed docker scripts (#1432) * Use bundler icon for files with .gemfile extension (#1430) * Add support for rubocop (#1436) * Add support for rubocop * Adjust icons to art guidelines. * Add support for tslint.yaml & tslint.yml (#1438) * #1434 Support for tsconfig.yaml and tsconfig.yml * Fixed tslint * Removed yaml extension for tsconfig * Add "asm" id to assembly. (#1450) * Remove "yml" file extension declaration. (#1451) This file extension is already supported natively from the editor. * Add support for docker test filename. (#1452) * Add support for SystemVerilog. (#1453) * Add support for Verilog. (#1454) * Fix rejection handling of "findFiles". (#1463) * Add vscode-icons-js to related (#1464) * Update dependencies. (#1467) * README fix link: Customization, not Configuration (#1448) * README fie link: Customization, not Configuration * Correcting typo link. * Fix package managers lock files. (#1468) * 7.20.0 (#1466) * 7.20.0 * 1464 added * Update CHANGELOG. * version bump * Typo?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is inspired by @torn4dom4n and should fix #1336 and close #1335.
If you think that these proposed changes can be improved further or you believe that they require more changes, please feel free to discuss them here.