Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sinon syntax sugar for promises. #1504

Merged

Conversation

JimiC
Copy link
Member

@JimiC JimiC commented Mar 11, 2018

Changes proposed:

  • Add
  • Delete

I now know Sinon better.

@JimiC JimiC added this to the Next milestone Mar 11, 2018
@JimiC JimiC requested a review from a team March 11, 2018 22:03
@codecov
Copy link

codecov bot commented Mar 11, 2018

Codecov Report

Merging #1504 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1504   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          48      48           
  Lines        2621    2621           
  Branches      133     133           
======================================
  Hits         2621    2621
Impacted Files Coverage Δ
test/init/projectAutoDetection.test.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3c748f...a6a8d42. Read the comment docs.

@robertohuertasm robertohuertasm merged commit d347465 into vscode-icons:master Mar 11, 2018
@JimiC JimiC deleted the use_stub_resolves_rejects branch March 11, 2018 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants