Add the Flash icon for .swf, .swc and .sol #200
Conversation
.sol is a local shared object, aka flash cookie
|
It's ok but I would rather make the icon smaller. Let's put some space between the border and the icon. Let's standarize it in 2 pixels of margin as per some other icons in the extension. #193 |
|
@robertohuertasm Okey. |
|
The HaxeDevelop icon I added also didn't have any margins I think. Neither did Lime really (#182), but I don't think it's necessary there? |
|
I don't think so, don't worry about them. In fact, your lime icon had more than 2px margin although only vertical. It's not a common rule because most of the icons that we currently have are not equal but just to make the icons feel more or less right with the others that we have. If we're making a square icon full 32px it's going to be seen as bigger. It's more a perceptive issue than numeric. @jens1o @Gama11 |
|
I have actually noticed that the HaxeDevelop icon appears bigger than the others, so I'd like to change that one. |
|
Done! |
|
You need to also add them to the icons.zip. |
|
As mentioned previously:
|
|
Oh, I overlooked this notice. But you could create a new branch, in which you update the zip file. For every PR, I create a different branch. |
|
What would that do? |
|
You can create a new branch, which does not affect the other files. Git just add the binaries, so you can apply multiple patches to each other. |
|
I'm well aware of that. I'm actually trying to avoid creating merge conflicts with your PRs, not my own. |
|
I thought it just add or remove them? In a zip, it would add them, don't it? |
|
Hm.. I thought Git might just treat .zip as a binary file. Maybe not! |
|
Nice thing! ❤️ |
|
Awesome! |
.sol is a local shared object, aka flash cookie
Didn't update icons.zip to avoid merge conflicts with the other PRs.