Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add photoshop #193

Merged
merged 10 commits into from
Aug 27, 2016
Merged

add photoshop #193

merged 10 commits into from
Aug 27, 2016

Conversation

jens1o
Copy link
Member

@jens1o jens1o commented Aug 27, 2016

_Fixes #191_

Changes proposed:

  • Add
  • Prepare
  • Delete
  • Fix

Things I've done:

  • I've pulled the latest master branch
  • I've run npm install to install all the dependenies
  • I've checked my code, it is clean.
  • I've run ESLint.
  • My pull request fixes an issue, I referenced the issue.
  • My pull request is not too big, otherwise I've already squashed it.
  • I've run npm run build to build the extension. (If I had done something with the extension.)

add psd files

@robertohuertasm
Copy link
Member

robertohuertasm commented Aug 27, 2016

@jens1o can we make this icon a little bit smaller? You're using the 32x32 without leaving any margin and looks a little bit bigger than the other ones.
Take a look at #200

@jens1o
Copy link
Member Author

jens1o commented Aug 27, 2016

What's the standard margin? There are no informations for that.

@robertohuertasm
Copy link
Member

You're absolutely right. Take a look at #200 2px

@robertohuertasm
Copy link
Member

@jens1o still to PR pending. Let me know when they're ready to merge 😉

@jens1o
Copy link
Member Author

jens1o commented Aug 27, 2016

I'd forget, sorry. Coming now.

@jens1o
Copy link
Member Author

jens1o commented Aug 27, 2016

ready

@robertohuertasm robertohuertasm merged commit a3757c5 into vscode-icons:master Aug 27, 2016
@jens1o jens1o deleted the jens1o-photoshop branch August 28, 2016 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants