Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reactivation issue #2019

Merged
merged 2 commits into from
Apr 23, 2019
Merged

Conversation

JimiC
Copy link
Member

@JimiC JimiC commented Apr 23, 2019

Fixes #2017

Changes proposed:

  • Fix

The fix includes the following logic:

  • Do nothing if it's an extension update.
  • Do the cleanup only on a single installation

This fix will work when updating to the next release after the one that includes this fix.

@JimiC JimiC added this to the Next milestone Apr 23, 2019
@JimiC JimiC requested a review from a team April 23, 2019 08:39
@codecov
Copy link

codecov bot commented Apr 23, 2019

Codecov Report

Merging #2019 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2019   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          78      78           
  Lines        5914    5948   +34     
  Branches      137     138    +1     
======================================
+ Hits         5914    5948   +34
Impacted Files Coverage Δ
src/configuration/configManager.ts 100% <100%> (ø) ⬆️
test/configuration/configManager.test.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56f18c5...44464ed. Read the comment docs.

@robertohuertasm robertohuertasm merged commit 983a20b into vscode-icons:master Apr 23, 2019
@JimiC JimiC deleted the fix-reactivation branch April 24, 2019 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] vscode-icons needs re-activation after new version installation and editor restart
2 participants