Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Azure folder #2081

Merged
merged 3 commits into from
Jun 9, 2019

Conversation

KingDarBoja
Copy link
Member

References #650

Changes proposed:

  • Add
  • Delete
  • Fix
  • Prepare

@codecov
Copy link

codecov bot commented Jun 9, 2019

Codecov Report

Merging #2081 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2081   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          78      78           
  Lines        5959    5959           
  Branches      138     138           
======================================
  Hits         5959    5959
Impacted Files Coverage Δ
src/iconsManifest/supportedFolders.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30fb602...ed88b66. Read the comment docs.

jens1o
jens1o previously approved these changes Jun 9, 2019
@JimiC
Copy link
Member

JimiC commented Jun 9, 2019

I would also add a dotted named version. You never know how it's used. Other than that LGTM.

@robertohuertasm
Copy link
Member

I also agree with @JimiC. Waiting for that small addition to merge it. Good work! 😊

@robertohuertasm robertohuertasm merged commit ac10c7f into vscode-icons:master Jun 9, 2019
@KingDarBoja KingDarBoja deleted the azure-folder-icon branch June 11, 2019 13:58
@robertohuertasm robertohuertasm added this to the Next milestone Jun 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants