Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Firestore Indexes #2286

Merged
merged 2 commits into from
Nov 19, 2019
Merged

Add support for Firestore Indexes #2286

merged 2 commits into from
Nov 19, 2019

Conversation

KingDarBoja
Copy link
Member

Fixes #2284

Changes proposed:

  • Add
  • Delete
  • Fix
  • Prepare

@KingDarBoja KingDarBoja added this to the Next milestone Nov 4, 2019
robertohuertasm
robertohuertasm approved these changes Nov 19, 2019
View reviewed changes
Copy link
Member

@robertohuertasm robertohuertasm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@robertohuertasm robertohuertasm merged commit b4adfa7 into vscode-icons:master Nov 19, 2019
@KingDarBoja KingDarBoja deleted the enhancement/firestore-indexes branch December 25, 2019 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertohuertasm robertohuertasm robertohuertasm approved these changes

@JimiC JimiC Awaiting requested review from JimiC

Assignees
No one assigned
Labels
file icons
Projects
None yet
Milestone
9.6.0
Development

Successfully merging this pull request may close these issues.

[Icon Request] Support for Firebase Firestore Index JSON File
2 participants
@KingDarBoja @robertohuertasm