Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(typings): add types folder icon #3022

Merged
merged 4 commits into from
Jul 10, 2022

Conversation

sasial-dev
Copy link
Contributor

I promise this is the last one for today

Changes proposed:

Add types to the typings folder icon

@robertohuertasm
Copy link
Member

😁 No problem @sasial-dev! Thank you for your hard work. I won't have time today for reviewing more PRs. I expect to have more time during the week. I'm going to make a release with what we have already merged and prepare a new one for this week (hopefully).

@DrJume
Copy link
Contributor

DrJume commented Jun 2, 2022

Why did you chose the green typings icon over the regular blue TypeScript folder icon for types?

I think a folder named 'types' contains regular exported types and interfaces for TypeScript in .ts files.

@PAXANDDOS
Copy link
Contributor

Why did you choose the green typings icon over the regular blue TypeScript folder icon for types?

I think a folder named 'types' contains regular exported types and interfaces for TypeScript in .ts files.

I believe that blue TypeScript icons are for source files, where is the actual code stored (.ts). And green ones are made specifically for types (folders and .d.ts files). So that could be easy to tell them apart without reading the file extension.

Copy link
Member

@robertohuertasm robertohuertasm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Thanks for your contribution ❤️

@robertohuertasm robertohuertasm enabled auto-merge (squash) July 10, 2022 17:20
@robertohuertasm robertohuertasm added this to the Next milestone Jul 10, 2022
@robertohuertasm robertohuertasm merged commit 9c11555 into vscode-icons:master Jul 10, 2022
@sasial-dev sasial-dev deleted the icons/types branch August 7, 2022 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants