-
-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update test workflow #3332
Update test workflow #3332
Conversation
d70ca2e
to
c74184e
Compare
@robertohuertasm No idea why the PR has no access to secrets although the checkbox for "Allow edits and access to secrets by maintainers" is checked. |
194eda9
to
473d96b
Compare
Just found out why access to secrets worked on my testing and not in the PR. Will look for a potential workaround or revert to the existing code coverage workflow. |
072530b
to
b472245
Compare
@robertohuertasm If you find some time pls do a review so we can merge this PR and iron out any issue that may lurk. |
- Upgrading node version - Allow fail on non-essential node versions - Cancel workflow when another commit is made on the same branch - Run jobs on batch of 3 - Improve code coverage workflow
Oh crap. Now I have to work on the second part of the update. @robertohuertasm Pls hold any release until I submit the rest. |
What do you need to do? Maybe I can help you with that. |
I have done it when I worked on the workflow update. I just have to bring it up to speed. Some rebase and potential fixes for issues that may have arise since. Hopefully I can resolve it in a couple of hours. |
Ok, I'll try to fix some pending PRs in the meantime. |
Note: This is part 1 of 2 for the dependencies update. This PR must be merged first before the Dependencies Update PR can be submitted.