Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test workflow #3332

Merged
merged 4 commits into from
Jan 14, 2024
Merged

Conversation

JimiC
Copy link
Member

@JimiC JimiC commented Aug 8, 2023

  • Upgrading node version
  • Allow fail on non-essential node versions
  • Cancel workflow when another commit is made on the same branch
  • Run jobs on batch of 3
  • Improving code coverage workflow
  • Upload code coverage directly if development is being done withing the repo (only the dev team is allowed to do that), otherwise use artifacts and use another workflow to ensure no secrets are leaked

Note: This is part 1 of 2 for the dependencies update. This PR must be merged first before the Dependencies Update PR can be submitted.

@JimiC JimiC added the devops label Aug 8, 2023
@JimiC JimiC force-pushed the workflow_test branch 2 times, most recently from d70ca2e to c74184e Compare August 8, 2023 07:35
@JimiC
Copy link
Member Author

JimiC commented Aug 8, 2023

@robertohuertasm No idea why the PR has no access to secrets although the checkbox for "Allow edits and access to secrets by maintainers" is checked.

@JimiC JimiC force-pushed the workflow_test branch 2 times, most recently from 194eda9 to 473d96b Compare August 11, 2023 06:56
@JimiC
Copy link
Member Author

JimiC commented Aug 11, 2023

Just found out why access to secrets worked on my testing and not in the PR.
https://securitylab.github.com/research/github-actions-preventing-pwn-requests/

Will look for a potential workaround or revert to the existing code coverage workflow.
Update: Found a workaround

@JimiC JimiC force-pushed the workflow_test branch 7 times, most recently from 072530b to b472245 Compare August 11, 2023 08:54
@JimiC JimiC marked this pull request as draft August 11, 2023 09:57
@JimiC JimiC marked this pull request as ready for review August 11, 2023 12:18
@JimiC
Copy link
Member Author

JimiC commented Aug 11, 2023

@robertohuertasm If you find some time pls do a review so we can merge this PR and iron out any issue that may lurk.

- Upgrading node version
- Allow fail on non-essential node versions
- Cancel workflow when another commit is made on the same branch
- Run jobs on batch of 3
- Improve code coverage workflow
@robertohuertasm robertohuertasm self-assigned this Jan 14, 2024
@robertohuertasm robertohuertasm merged commit 282c14d into vscode-icons:master Jan 14, 2024
12 of 13 checks passed
@JimiC
Copy link
Member Author

JimiC commented Jan 14, 2024

Oh crap. Now I have to work on the second part of the update. @robertohuertasm Pls hold any release until I submit the rest.

@robertohuertasm
Copy link
Member

What do you need to do? Maybe I can help you with that.

@JimiC
Copy link
Member Author

JimiC commented Jan 14, 2024

I have done it when I worked on the workflow update. I just have to bring it up to speed. Some rebase and potential fixes for issues that may have arise since. Hopefully I can resolve it in a couple of hours.

@JimiC JimiC deleted the workflow_test branch January 14, 2024 12:21
@robertohuertasm
Copy link
Member

Ok, I'll try to fix some pending PRs in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants