Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added new webpack folder support #448

Merged
merged 1 commit into from
Nov 20, 2016
Merged

Conversation

robertohuertasm
Copy link
Member

@robertohuertasm robertohuertasm commented Nov 20, 2016

Changes proposed:

  • Add
  • Prepare
  • Delete
  • Fix

Things I've done:

  • I've pulled the latest master branch.
  • I've run npm install to install all the dependencies.
  • I've run ESLint.
  • My pull request fixes an issue, I referenced the issue.
  • I've run npm run build to build the extension.

I know it's not svg. I will prepare the svg for folders during the week but I was willing to deliver a new version today and I wanted this 😁

@robertohuertasm
Copy link
Member Author

This also ammends merge #447

@robertohuertasm robertohuertasm merged commit 5390a36 into master Nov 20, 2016
@robertohuertasm robertohuertasm deleted the feature-webpack-folder branch November 20, 2016 20:42
@JimiC
Copy link
Member

JimiC commented Nov 20, 2016

@robertohuertasm While you are at it you may wonna update the .vscodeignore file. It needs the addition of images/*.ai and ``Dockerfile`.

@robertohuertasm
Copy link
Member Author

@JimiC too late... Next release... 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants