-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add connection pools support #20
base: master
Are you sure you want to change the base?
Conversation
is present)." | ||
`(bordeaux-threads:with-lock-held (*pool-lock*) ,@body)) | ||
|
||
(defun get-from-pool (&optional group) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can write (&optional (group "default"))
Hi again, But before it can be merged into master we need to do the following:
|
You are right! |
I will spend some time to take a look at Jedis(an Java implement of redis-cli). As I know, Jedis has perfect feature about connection pools. |
You can take a look at the tests already present. |
Well, actually, my experience with Jedis is one of the reasons I think working supporting connection pools is hard :) (It was, actually, quite painful experience, when connections became unusable completely unpredictably and it was very hard to tackle that) |
Thanks for your patience! |
You could check out https://github.com/quasi/pooler for pooling functionality |
Add connection pools support.
Usage: