Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too ?many? #244

Closed
ncannasse opened this issue Jun 14, 2018 · 6 comments
Closed

Too ?many? #244

ncannasse opened this issue Jun 14, 2018 · 6 comments

Comments

@ncannasse
Copy link
Member

I just discovered a new Haxe syntax :)

image

@Gama11
Copy link
Member

Gama11 commented Jun 14, 2018

? is used for printing monomorphs, because the Unknown<0> we had previously looks stupid. :) We even highlight this somewhat nicely in hover hints:

Open to better suggestions though. Ideally we just wouldn't ever have any monomorphs in completion. ;)

@ncannasse
Copy link
Member Author

how come it's a Monomorph if we're having a String constant ?
Also, I would prefer in the case an argument is a monomorph to simply remove ":?" instead of displaying it

@ncannasse
Copy link
Member Author

(for the cases it's just a monomorph, I understand the need for ? in type parameters)

@Gama11
Copy link
Member

Gama11 commented Jun 14, 2018

That may be an option. Why it's a monomorph, no idea. @Simn? :)

@nadako
Copy link
Member

nadako commented Jun 14, 2018

I think that's what I originally did for function arguments (just don't display anything for unknown types)

@Simn
Copy link
Member

Simn commented Jun 14, 2018

Not sure why that's a monomorph, might be a return_partial_type thing.

Gama11 added a commit to vshaxe/haxe-language-server that referenced this issue Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants