SIM7600 Protocol enhancements (Fixes #624) #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrlanoisTA2023
added a commit
to jrlanoisTA2023/TinyGSM
that referenced
this pull request
Jan 12, 2024
PRs that fixes were incorporated for include: vshymanskyy#642 vshymanskyy#678 vshymanskyy#736 vshymanskyy#746
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
restartImpl()is not enough, a real module takes at least 23 seconds to reboot before it starts to respond to any AT commands.getGPSImpl(...)method expects two extra","in the response that breaks theiaccuracyvariable and also causes it to skip theOKpart in the end of the response that leads to the 3-seconds waiting until the timeout occurs. After that thewaitResponse()in the last line of that method also does not receive the properOKand also waits 1 extra second until the timeout.