Bug #681912: Sparkle naively double-escapes enclosure URLs

vslavik · Nov 26, 2010 · 00b6726 · 00b6726
1 parent 7baf505
commit 00b6726
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/SUAppcastItem.m b/SUAppcastItem.m
@@ -180,7 +180,8 @@ - (BOOL)isDeltaUpdate
             [self setDate:[dict objectForKey:@"pubDate"]];
             [self setItemDescription:[dict objectForKey:@"description"]];
 
-            [self setFileURL:[NSURL URLWithString:[[enclosure objectForKey:@"url"] stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding]]];
+			NSString *fileURLString = [[[enclosure objectForKey:@"url"] stringByReplacingPercentEscapesUsingEncoding:NSUTF8StringEncoding] stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding];
+            [self setFileURL:[NSURL URLWithString:fileURLString]];
             [self setDSASignature:[enclosure objectForKey:@"sparkle:dsaSignature"]];		
 
             [self setVersionString:newVersion];