Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add update closed event #272

Conversation

BrunoBibboVoicemod
Copy link

This is a solution candidate for #127 issue (duplicated #271) where WinSparkle library user can suscribe to a new event emitted when the updater closes (win_sparkle_set_update_closed_callback).

@vslavik
Copy link
Owner

vslavik commented May 17, 2024

Sorry, I still (hence the delay in response...) don't get why should this be a separate callback event and not just win_sparkle_set_update_cancelled_callback — it's effectively the same thing, isn't it?

It gets worse, though — I then noticed that there already is win_sparkle_set_update_dismissed_callback, contradicting the above opinion. And that one is never actually called anywhere.

So I think, but am open to arguments, that it should be separate event after all - simply because it was added to the API, however broken, a while back - but that this code should use win_sparkle_set_update_dismissed_callback instead of adding a new one.

@vslavik
Copy link
Owner

vslavik commented Jun 19, 2024

I was wrong about the dismissed callback. The dismissed and cancelled callbacks are a hot mess, but adding yet another confusing one is not a solution, so I decided to close this PR and cleanup the existing callbacks instead.

@vslavik vslavik closed this Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants