Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win_sparkle_update_cancelled_callback not called when closing installation window #127

Closed
glaubitz opened this issue Feb 2, 2017 · 2 comments

Comments

@glaubitz
Copy link

glaubitz commented Feb 2, 2017

Currently, the win_sparkle_update_cancelled_callback callback function is called when the user click "Skip Update", "Remind Me Later" or when the "Cancel" button is clicked when the update is being downloaded.

However, win_sparkle_update_cancelled_callback is not called when the user just closes the "Ready to install" dialog instead of clicking "Install updates" although this effectively cancels the update process as well.

@vslavik
Copy link
Owner

vslavik commented Feb 2, 2017

Please submit a PR with the fix, then. As one of the very few users of this callback, you’re in the best position to do it and contribute back.

@buwen-D

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants