A couple of -Wconversion fixes #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me... |
This fixes a few -Wconversion gcc warnings and, more importantly, actually ensures that there are no integer overflows in the code which might result in real problems. Add checked_int_cast() helper which is used to check for such overflows in all the places where gcc flags of them and throws an exception instead of using a wrong (wrapped) value if it happens.
This fixes another -Wconversion warning given by g++ 4.8 but, surprisingly, not later versions for some reason.
This is unnecessary and results in -Wsign-conversion gcc warning.
There are no more warnings of this kind in the current sources, ensure that new ones are not introduced later by making them immediately visible (and fatal) in CI builds.
Unlike gcc, clang enables -Wsign-conversion when -Wconversion is specified for C++ code too (gcc does it for C only), and enabling -Wconversion uncovered a couple of instances where this warning was given. Fix them and enable -Wsign-conversion for gcc too for consistency and fix a bunch more of very similar warnings given by gcc which were, surprisingly, not given by clang, by using checked_size_t_cast() helper similar to checked_int_cast() added in the previous commit.
|
OK, I'm going to merge this one too now that it actually passes the CI builds (somehow I didn't get any of the errors in the previous build with my local g++...). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.