Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination #17

Closed
vspedr opened this issue Oct 17, 2019 · 10 comments
Closed

Add pagination #17

vspedr opened this issue Oct 17, 2019 · 10 comments

Comments

@vspedr
Copy link
Owner

vspedr commented Oct 17, 2019

As the list increases, loading too many items at once may cause some performance issues. We could use pagination to limit the amount of items displayed.

@fuku710
Copy link
Contributor

fuku710 commented Oct 17, 2019

I want to do this issue!

@vspedr
Copy link
Owner Author

vspedr commented Oct 17, 2019

Hi @fuku710, feel free to give it a try!

@vspedr
Copy link
Owner Author

vspedr commented Oct 18, 2019

Hey @fuku710 just a heads up, if you're working on this take a look at #20, I will merge it soon so pagination should probably take it into account

@fuku710
Copy link
Contributor

fuku710 commented Oct 18, 2019

@vspedr OK

@Iodine-
Copy link
Contributor

Iodine- commented Oct 19, 2019

Happy to assist with this too if needed @fuku710 - just let me know if there is anything I can do

@fuku710
Copy link
Contributor

fuku710 commented Oct 19, 2019

Thank you @Iodine- !
I will write code hard but if you know better code to tell me

@akankshajai
Copy link

Is this still open? I want to work on this.

@vspedr
Copy link
Owner Author

vspedr commented Oct 19, 2019

Hi @akankshajai, sorry, this is already implemented but I forgot to close the issue. Feel free to browse the issues and pick another one!

@vspedr vspedr closed this as completed Oct 19, 2019
@vspedr
Copy link
Owner Author

vspedr commented Oct 19, 2019

Implemented in #22

@akankshajai
Copy link

akankshajai commented Oct 19, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants